Title: [199403] trunk/Tools
- Revision
- 199403
- Author
- [email protected]
- Date
- 2016-04-12 20:57:36 -0700 (Tue, 12 Apr 2016)
Log Message
Python test webkitpy.common.system.executive_unittest.ExecutiveTest.serial_test_kill_process is flaky
https://bugs.webkit.org/show_bug.cgi?id=155367
Reviewed by Darin Adler.
* Scripts/webkitpy/common/system/executive.py: (Executive.kill_process):
Don't flakily consume the return code with waitpid, callers need to do waitpid on
their own. Not sure if this line of code was even intentional.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (199402 => 199403)
--- trunk/Tools/ChangeLog 2016-04-13 03:14:14 UTC (rev 199402)
+++ trunk/Tools/ChangeLog 2016-04-13 03:57:36 UTC (rev 199403)
@@ -1,3 +1,14 @@
+2016-04-12 Alexey Proskuryakov <[email protected]>
+
+ Python test webkitpy.common.system.executive_unittest.ExecutiveTest.serial_test_kill_process is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=155367
+
+ Reviewed by Darin Adler.
+
+ * Scripts/webkitpy/common/system/executive.py: (Executive.kill_process):
+ Don't flakily consume the return code with waitpid, callers need to do waitpid on
+ their own. Not sure if this line of code was even intentional.
+
2016-04-12 Myles C. Maxfield <[email protected]>
[OS X] Flakey crash after ScrollAnimatorMac destruction
Modified: trunk/Tools/Scripts/webkitpy/common/system/executive.py (199402 => 199403)
--- trunk/Tools/Scripts/webkitpy/common/system/executive.py 2016-04-13 03:14:14 UTC (rev 199402)
+++ trunk/Tools/Scripts/webkitpy/common/system/executive.py 2016-04-13 03:57:36 UTC (rev 199403)
@@ -205,7 +205,6 @@
# already exited, and forcefully kill it if SIGTERM wasn't enough.
os.kill(pid, signal.SIGTERM)
os.kill(pid, signal.SIGKILL)
- _ = os.waitpid(pid, os.WNOHANG)
except OSError, e:
if e.errno == errno.EAGAIN:
if retries_left <= 0:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
