Title: [199464] releases/WebKitGTK/webkit-2.12
- Revision
- 199464
- Author
- [email protected]
- Date
- 2016-04-13 05:18:31 -0700 (Wed, 13 Apr 2016)
Log Message
Make animation events non-cancelable
https://bugs.webkit.org/show_bug.cgi?id=78110
Reviewed by Dan Bates.
Source/WebCore:
Make the animation events non-cancelable.
Test: animations/animation-events-not-cancelable.html
* dom/AnimationEvent.cpp:
(WebCore::AnimationEvent::AnimationEvent):
LayoutTests:
* animations/animation-events-not-cancelable-expected.txt: Added.
* animations/animation-events-not-cancelable.html: Added.
Modified Paths
Added Paths
Diff
Modified: releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog (199463 => 199464)
--- releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog 2016-04-13 12:16:17 UTC (rev 199463)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog 2016-04-13 12:18:31 UTC (rev 199464)
@@ -1,3 +1,13 @@
+2016-03-24 Simon Fraser <[email protected]>
+
+ Make animation events non-cancelable
+ https://bugs.webkit.org/show_bug.cgi?id=78110
+
+ Reviewed by Dan Bates.
+
+ * animations/animation-events-not-cancelable-expected.txt: Added.
+ * animations/animation-events-not-cancelable.html: Added.
+
2016-03-31 Zalan Bujtas <[email protected]>
Add a -mismatch test case for r198785.
Added: releases/WebKitGTK/webkit-2.12/LayoutTests/animations/animation-events-not-cancelable-expected.txt (0 => 199464)
--- releases/WebKitGTK/webkit-2.12/LayoutTests/animations/animation-events-not-cancelable-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/animations/animation-events-not-cancelable-expected.txt 2016-04-13 12:18:31 UTC (rev 199464)
@@ -0,0 +1,15 @@
+Tests that animation events are not cancelable.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+animationstart:
+PASS event.cancelable is false
+animationiteration:
+PASS event.cancelable is false
+animationend:
+PASS event.cancelable is false
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: releases/WebKitGTK/webkit-2.12/LayoutTests/animations/animation-events-not-cancelable.html (0 => 199464)
--- releases/WebKitGTK/webkit-2.12/LayoutTests/animations/animation-events-not-cancelable.html (rev 0)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/animations/animation-events-not-cancelable.html 2016-04-13 12:18:31 UTC (rev 199464)
@@ -0,0 +1,53 @@
+<!DOCTYPE html>
+<html>
+<head>
+<script src=""
+<style>
+#box {
+ height: 10px;
+ width: 10px;
+ background-color: blue;
+ position: relative;
+}
+#box.running {
+ animation: move 0.02s 2 linear;
+}
+@keyframes move {
+ from { left: 0px; }
+ to { left: 10px; }
+}
+</style>
+</head>
+<body>
+<div id="box"></div>
+
+<p id="description"></p>
+<div id="console"></div>
+<script>
+jsTestIsAsync = true;
+
+description('Tests that animation events are not cancelable.');
+
+var box = document.getElementById('box');
+box.addEventListener('animationstart', function(event) {
+ debug(event.type + ':');
+ shouldBe('event.cancelable', 'false');
+}, false);
+
+box.addEventListener('animationiteration', function(event) {
+ debug(event.type + ':');
+ shouldBe('event.cancelable', 'false');
+}, false);
+
+box.addEventListener('animationend', function(event) {
+ debug(event.type + ':');
+ shouldBe('event.cancelable', 'false');
+ finishJSTest();
+}, false);
+
+box.classList.add('running');
+
+</script>
+<script src=""
+</body>
+</html>
Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog (199463 => 199464)
--- releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog 2016-04-13 12:16:17 UTC (rev 199463)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog 2016-04-13 12:18:31 UTC (rev 199464)
@@ -1,3 +1,17 @@
+2016-03-24 Simon Fraser <[email protected]>
+
+ Make animation events non-cancelable
+ https://bugs.webkit.org/show_bug.cgi?id=78110
+
+ Reviewed by Dan Bates.
+
+ Make the animation events non-cancelable.
+
+ Test: animations/animation-events-not-cancelable.html
+
+ * dom/AnimationEvent.cpp:
+ (WebCore::AnimationEvent::AnimationEvent):
+
2016-03-29 Zalan Bujtas <[email protected]>
REGRESSION (r196813): Missing plug-in placeholder is missing
Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/dom/AnimationEvent.cpp (199463 => 199464)
--- releases/WebKitGTK/webkit-2.12/Source/WebCore/dom/AnimationEvent.cpp 2016-04-13 12:16:17 UTC (rev 199463)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/dom/AnimationEvent.cpp 2016-04-13 12:18:31 UTC (rev 199464)
@@ -38,7 +38,7 @@
}
AnimationEvent::AnimationEvent(const AtomicString& type, const String& animationName, double elapsedTime)
- : Event(type, true, true)
+ : Event(type, true, false)
, m_animationName(animationName)
, m_elapsedTime(elapsedTime)
{
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
