Log Message
REGRESSION (r199401): Internal builds of Safari hang on launch https://bugs.webkit.org/show_bug.cgi?id=156545 <rdar://problem/25697779>
As pointed out by Darin Adler, remove RELEASE_ASSERT() that I inadvertently left in WebCore::secCodeForProcess() as part of r199504. For now, we handle SecCodeCopyGuestWithAttributes() returning an error. In a subsequent commit we will look to re-introduce the use of a RELEASE_ASSERT() to enforce the invariant that SecCodeCopyGuestWithAttributes() returns a success status. * Shared/mac/CodeSigning.mm: (WebKit::secCodeForProcess):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (199527 => 199528)
--- trunk/Source/WebKit2/ChangeLog 2016-04-14 02:39:58 UTC (rev 199527)
+++ trunk/Source/WebKit2/ChangeLog 2016-04-14 03:21:29 UTC (rev 199528)
@@ -1,3 +1,18 @@
+2016-04-13 Daniel Bates <[email protected]>
+
+ REGRESSION (r199401): Internal builds of Safari hang on launch
+ https://bugs.webkit.org/show_bug.cgi?id=156545
+ <rdar://problem/25697779>
+
+ As pointed out by Darin Adler, remove RELEASE_ASSERT() that I inadvertently left in
+ WebCore::secCodeForProcess() as part of r199504. For now, we handle
+ SecCodeCopyGuestWithAttributes() returning an error. In a subsequent commit we will
+ look to re-introduce the use of a RELEASE_ASSERT() to enforce the invariant that
+ SecCodeCopyGuestWithAttributes() returns a success status.
+
+ * Shared/mac/CodeSigning.mm:
+ (WebKit::secCodeForProcess):
+
2016-04-13 Brady Eidson <[email protected]>
Modern IDB (Blob support): Support retrieving Blobs from IDB.
Modified: trunk/Source/WebKit2/Shared/mac/CodeSigning.mm (199527 => 199528)
--- trunk/Source/WebKit2/Shared/mac/CodeSigning.mm 2016-04-14 02:39:58 UTC (rev 199527)
+++ trunk/Source/WebKit2/Shared/mac/CodeSigning.mm 2016-04-14 03:21:29 UTC (rev 199528)
@@ -55,7 +55,6 @@
WTFLogAlways("SecCodeCopyGuestWithAttributes() failed with error: %ld\n", static_cast<long>(errorCode));
return nullptr;
}
- RELEASE_ASSERT(!SecCodeCopyGuestWithAttributes(nullptr, attributes.get(), kSecCSDefaultFlags, &code));
return adoptCF(code);
}
_______________________________________________ webkit-changes mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-changes
