Title: [199569] trunk/Source/WebCore
- Revision
- 199569
- Author
- [email protected]
- Date
- 2016-04-14 17:23:29 -0700 (Thu, 14 Apr 2016)
Log Message
REGRESSION (r158956): Remove vestigial range code in FileReaderLoader class after removing ENABLE(STREAM)
<http://webkit.org/b/156609>
Reviewed by Brent Fulgham.
This code was left behind when ENABLE(STREAM) was removed in
November 2013.
* fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::FileReaderLoader): Remove
initializers.
(WebCore::FileReaderLoader::start): Remove code that uses
m_hasRange, which is always false.
(WebCore::FileReaderLoader::didReceiveResponse): Ditto.
* fileapi/FileReaderLoader.h:
(WebCore::FileReaderLoader): Remove unused instance variables.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (199568 => 199569)
--- trunk/Source/WebCore/ChangeLog 2016-04-15 00:01:13 UTC (rev 199568)
+++ trunk/Source/WebCore/ChangeLog 2016-04-15 00:23:29 UTC (rev 199569)
@@ -1,3 +1,22 @@
+2016-04-14 David Kilzer <[email protected]>
+
+ REGRESSION (r158956): Remove vestigial range code in FileReaderLoader class after removing ENABLE(STREAM)
+ <http://webkit.org/b/156609>
+
+ Reviewed by Brent Fulgham.
+
+ This code was left behind when ENABLE(STREAM) was removed in
+ November 2013.
+
+ * fileapi/FileReaderLoader.cpp:
+ (WebCore::FileReaderLoader::FileReaderLoader): Remove
+ initializers.
+ (WebCore::FileReaderLoader::start): Remove code that uses
+ m_hasRange, which is always false.
+ (WebCore::FileReaderLoader::didReceiveResponse): Ditto.
+ * fileapi/FileReaderLoader.h:
+ (WebCore::FileReaderLoader): Remove unused instance variables.
+
2016-04-14 Alex Christensen <[email protected]>
Build fix after r199549.
Modified: trunk/Source/WebCore/fileapi/FileReaderLoader.cpp (199568 => 199569)
--- trunk/Source/WebCore/fileapi/FileReaderLoader.cpp 2016-04-15 00:01:13 UTC (rev 199568)
+++ trunk/Source/WebCore/fileapi/FileReaderLoader.cpp 2016-04-15 00:23:29 UTC (rev 199569)
@@ -60,9 +60,6 @@
, m_variableLength(false)
, m_bytesLoaded(0)
, m_totalBytes(0)
- , m_hasRange(false)
- , m_rangeStart(0)
- , m_rangeEnd(0)
, m_errorCode(0)
{
}
@@ -87,8 +84,6 @@
// Construct and load the request.
ResourceRequest request(m_urlForReading);
request.setHTTPMethod("GET");
- if (m_hasRange)
- request.setHTTPHeaderField(HTTPHeaderName::Range, String::format("bytes=%d-%d", m_rangeStart, m_rangeEnd));
ThreadableLoaderOptions options;
options.setSendLoadCallbacks(SendCallbacks);
@@ -142,10 +137,7 @@
// A negative value means that the content length wasn't specified, so the buffer will need to be dynamically grown.
if (length < 0) {
m_variableLength = true;
- if (m_hasRange)
- length = 1 + m_rangeEnd - m_rangeStart;
- else
- length = defaultBufferLength;
+ length = defaultBufferLength;
}
// Check that we can cast to unsigned since we have to do
Modified: trunk/Source/WebCore/fileapi/FileReaderLoader.h (199568 => 199569)
--- trunk/Source/WebCore/fileapi/FileReaderLoader.h 2016-04-15 00:01:13 UTC (rev 199568)
+++ trunk/Source/WebCore/fileapi/FileReaderLoader.h 2016-04-15 00:23:29 UTC (rev 199569)
@@ -114,10 +114,6 @@
unsigned m_bytesLoaded;
unsigned m_totalBytes;
- bool m_hasRange;
- unsigned m_rangeStart;
- unsigned m_rangeEnd;
-
int m_errorCode;
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
