Title: [199573] trunk/Tools
Revision
199573
Author
[email protected]
Date
2016-04-14 21:37:43 -0700 (Thu, 14 Apr 2016)

Log Message

Some GuardMalloc bots are not happy when running many parallel processes
https://bugs.webkit.org/show_bug.cgi?id=156614
rdar://problem/24711525

Reviewed by David Kilzer.

* Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (199572 => 199573)


--- trunk/Tools/ChangeLog	2016-04-15 03:42:21 UTC (rev 199572)
+++ trunk/Tools/ChangeLog	2016-04-15 04:37:43 UTC (rev 199573)
@@ -1,3 +1,13 @@
+2016-04-14  Alexey Proskuryakov  <[email protected]>
+
+        Some GuardMalloc bots are not happy when running many parallel processes
+        https://bugs.webkit.org/show_bug.cgi?id=156614
+        rdar://problem/24711525
+
+        Reviewed by David Kilzer.
+
+        * Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):
+
 2016-04-14  Brent Fulgham  <[email protected]>
 
         Make <a download> a runtime enabled option

Modified: trunk/Tools/Scripts/webkitpy/port/mac.py (199572 => 199573)


--- trunk/Tools/Scripts/webkitpy/port/mac.py	2016-04-15 03:42:21 UTC (rev 199572)
+++ trunk/Tools/Scripts/webkitpy/port/mac.py	2016-04-15 04:37:43 UTC (rev 199573)
@@ -155,7 +155,12 @@
         should_throttle_for_wk2 = self.get_option('webkit_test_runner') and default_count > 4
         # We also want to throttle for leaks bots.
         if should_throttle_for_wk2 or self.get_option('leaks'):
-            default_count = int(.75 * default_count)
+            if self.get_option('guard_malloc'):
+                # Some 12 core Macs get a lot of tests time out when running 18 WebKitTestRunner processes (it's not clear what this depends on).
+                # Running 12 processes resolves this, and doesn't seem to introduce a measurable performance degradation on other machines.
+                default_count = int(.5 * default_count)
+            else:
+                default_count = int(.75 * default_count)
 
         # Make sure we have enough ram to support that many instances:
         total_memory = self.host.platform.total_bytes_memory()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to