Title: [199598] trunk/Source/WebCore
- Revision
- 199598
- Author
- [email protected]
- Date
- 2016-04-15 11:24:32 -0700 (Fri, 15 Apr 2016)
Log Message
Calling SVGAnimatedPropertyTearOff::animationEnded() will crash if the SVG property is not animating
https://bugs.webkit.org/show_bug.cgi?id=156549
Patch by Said Abou-Hallawa <[email protected]> on 2016-04-15
Reviewed by Darin Adler.
A speculative fix for a crash which may happen when calling animationEnded()
of any SVGAnimatedProperty while it is not animating.
* svg/SVGAnimatedTypeAnimator.h:
(WebCore::SVGAnimatedTypeAnimator::executeAction):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (199597 => 199598)
--- trunk/Source/WebCore/ChangeLog 2016-04-15 18:08:13 UTC (rev 199597)
+++ trunk/Source/WebCore/ChangeLog 2016-04-15 18:24:32 UTC (rev 199598)
@@ -1,3 +1,16 @@
+2016-04-15 Said Abou-Hallawa <[email protected]>
+
+ Calling SVGAnimatedPropertyTearOff::animationEnded() will crash if the SVG property is not animating
+ https://bugs.webkit.org/show_bug.cgi?id=156549
+
+ Reviewed by Darin Adler.
+
+ A speculative fix for a crash which may happen when calling animationEnded()
+ of any SVGAnimatedProperty while it is not animating.
+
+ * svg/SVGAnimatedTypeAnimator.h:
+ (WebCore::SVGAnimatedTypeAnimator::executeAction):
+
2016-04-15 Jer Noble <[email protected]>
Unreviewed build fix for iOS simulator. Assert the correct variable.
Modified: trunk/Source/WebCore/svg/SVGAnimatedTypeAnimator.h (199597 => 199598)
--- trunk/Source/WebCore/svg/SVGAnimatedTypeAnimator.h 2016-04-15 18:08:13 UTC (rev 199597)
+++ trunk/Source/WebCore/svg/SVGAnimatedTypeAnimator.h 2016-04-15 18:24:32 UTC (rev 199598)
@@ -201,7 +201,8 @@
break;
case StopAnimationAction:
ASSERT(!type);
- property->animationEnded();
+ if (property->isAnimating())
+ property->animationEnded();
break;
case AnimValWillChangeAction:
ASSERT(!type);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
