Title: [199697] trunk
- Revision
- 199697
- Author
- [email protected]
- Date
- 2016-04-18 17:21:20 -0700 (Mon, 18 Apr 2016)
Log Message
WebKit should adopt journal_mode=wal for all SQLite databases.
https://bugs.webkit.org/show_bug.cgi?id=133496
Reviewed by Brady Eidson.
Enabling sqlite3 WAL mode on iOS causes a test failure, but appears just be something that should fail still failing, only in a different way.
Enabling & marking test as failing for now. Tracking test failure here:
https://bugs.webkit.org/show_bug.cgi?id=156718
Source/WebCore:
* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::open):
- enable on iOS.
LayoutTests:
* platform/ios-simulator/TestExpectations:
- storage/websql/alter-to-info-table.html [ Failure ]
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (199696 => 199697)
--- trunk/LayoutTests/ChangeLog 2016-04-18 23:07:54 UTC (rev 199696)
+++ trunk/LayoutTests/ChangeLog 2016-04-19 00:21:20 UTC (rev 199697)
@@ -1,3 +1,17 @@
+2016-04-18 Gavin Barraclough <[email protected]>
+
+ WebKit should adopt journal_mode=wal for all SQLite databases.
+ https://bugs.webkit.org/show_bug.cgi?id=133496
+
+ Reviewed by Brady Eidson.
+
+ Enabling sqlite3 WAL mode on iOS causes a test failure, but appears just be something that should fail still failing, only in a different way.
+ Enabling & marking test as failing for now. Tracking test failure here:
+ https://bugs.webkit.org/show_bug.cgi?id=156718
+
+ * platform/ios-simulator/TestExpectations:
+ - storage/websql/alter-to-info-table.html [ Failure ]
+
2016-04-18 Chris Dumez <[email protected]>
Crash in ElementDescendantIterator::operator--() when calling m_ancestorSiblingStack.last()
Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (199696 => 199697)
--- trunk/LayoutTests/platform/ios-simulator/TestExpectations 2016-04-18 23:07:54 UTC (rev 199696)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations 2016-04-19 00:21:20 UTC (rev 199697)
@@ -2541,6 +2541,7 @@
# storage tests that fail:
storage/websql/sql-error-codes.html [ Failure ]
+storage/websql/alter-to-info-table.html [ Failure ]
# iOS-specific tests that fail:
platform/ios-simulator/ios/compositing/overlap-page-scale.html [ Failure ]
Modified: trunk/Source/WebCore/ChangeLog (199696 => 199697)
--- trunk/Source/WebCore/ChangeLog 2016-04-18 23:07:54 UTC (rev 199696)
+++ trunk/Source/WebCore/ChangeLog 2016-04-19 00:21:20 UTC (rev 199697)
@@ -1,3 +1,18 @@
+2016-04-18 Gavin Barraclough <[email protected]>
+
+ WebKit should adopt journal_mode=wal for all SQLite databases.
+ https://bugs.webkit.org/show_bug.cgi?id=133496
+
+ Reviewed by Brady Eidson.
+
+ Enabling sqlite3 WAL mode on iOS causes a test failure, but appears just be something that should fail still failing, only in a different way.
+ Enabling & marking test as failing for now. Tracking test failure here:
+ https://bugs.webkit.org/show_bug.cgi?id=156718
+
+ * platform/sql/SQLiteDatabase.cpp:
+ (WebCore::SQLiteDatabase::open):
+ - enable on iOS.
+
2016-04-18 Brent Fulgham <[email protected]>
Remove support for X-Frame-Options in `<meta>`
Modified: trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp (199696 => 199697)
--- trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp 2016-04-18 23:07:54 UTC (rev 199696)
+++ trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp 2016-04-19 00:21:20 UTC (rev 199697)
@@ -115,7 +115,6 @@
if (!SQLiteStatement(*this, ASCIILiteral("PRAGMA temp_store = MEMORY;")).executeCommand())
LOG_ERROR("SQLite database could not set temp_store to memory");
-#if !PLATFORM(IOS)
SQLiteStatement walStatement(*this, ASCIILiteral("PRAGMA journal_mode=WAL;"));
if (walStatement.prepareAndStep() == SQLITE_ROW) {
#ifndef NDEBUG
@@ -125,7 +124,6 @@
#endif
} else
LOG_ERROR("SQLite database failed to set journal_mode to WAL, error: %s", lastErrorMsg());
-#endif
return isOpen();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
