Title: [199736] trunk/LayoutTests
- Revision
- 199736
- Author
- [email protected]
- Date
- 2016-04-19 12:06:47 -0700 (Tue, 19 Apr 2016)
Log Message
imported/w3c/web-platform-tests/streams/readable-streams/general.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=155760
Reviewed by Alexey Proskuryakov.
LayoutTests/imported/w3c:
Flakiness was coming from a callback being called after a timeout.
Timeout was set so that a double promise resolution (promise resolved
in another promise resolution callback) is done before calling the callback.
On some slow bots, the timeout was not big enough.
* web-platform-tests/streams/readable-streams/general.js: Increased the callback delay.
LayoutTests:
* TestExpectations: removed flaky expectation.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (199735 => 199736)
--- trunk/LayoutTests/ChangeLog 2016-04-19 18:39:09 UTC (rev 199735)
+++ trunk/LayoutTests/ChangeLog 2016-04-19 19:06:47 UTC (rev 199736)
@@ -1,3 +1,12 @@
+2016-04-19 Youenn Fablet <[email protected]>
+
+ imported/w3c/web-platform-tests/streams/readable-streams/general.https.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=155760
+
+ Reviewed by Alexey Proskuryakov.
+
+ * TestExpectations: removed flaky expectation.
+
2016-04-19 Mark Lam <[email protected]>
Re-landing: ES6: Implement String.prototype.split and RegExp.prototype[@@split].
Modified: trunk/LayoutTests/TestExpectations (199735 => 199736)
--- trunk/LayoutTests/TestExpectations 2016-04-19 18:39:09 UTC (rev 199735)
+++ trunk/LayoutTests/TestExpectations 2016-04-19 19:06:47 UTC (rev 199736)
@@ -742,7 +742,6 @@
webkit.org/b/148805 imported/w3c/css/css-multicol-1/multicol-span-all-child-001.xht [ ImageOnlyFailure ]
webkit.org/b/148884 imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection.html [ Pass Failure ]
-webkit.org/b/155760 imported/w3c/web-platform-tests/streams/readable-streams/general.https.html [ Pass Failure ]
webkit.org/b/148922 svg/as-object/svg-in-object-dynamic-attribute-change.html [ Pass ImageOnlyFailure ]
webkit.org/b/148925 svg/dom/svg-root-lengths.html [ Pass Failure ]
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (199735 => 199736)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-04-19 18:39:09 UTC (rev 199735)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-04-19 19:06:47 UTC (rev 199736)
@@ -1,3 +1,17 @@
+2016-04-19 Youenn Fablet <[email protected]>
+
+ imported/w3c/web-platform-tests/streams/readable-streams/general.https.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=155760
+
+ Reviewed by Alexey Proskuryakov.
+
+ Flakiness was coming from a callback being called after a timeout.
+ Timeout was set so that a double promise resolution (promise resolved
+ in another promise resolution callback) is done before calling the callback.
+ On some slow bots, the timeout was not big enough.
+
+ * web-platform-tests/streams/readable-streams/general.js: Increased the callback delay.
+
2016-04-17 Youenn Fablet <[email protected]>
[Fetch API] Consume HTTP data as a ReadableStream
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/general.js (199735 => 199736)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/general.js 2016-04-19 18:39:09 UTC (rev 199735)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/general.js 2016-04-19 19:06:47 UTC (rev 199736)
@@ -292,7 +292,8 @@
}
});
- return delay(1).then(() => {
+ // WEBKIT modification: delay(1) replaced by delay(10) to ensure that pull promise is resolved before calling below thened code.
+ return delay(10).then(() => {
assert_equals(pullCount, 1, 'pull should be called once start finishes');
const reader = rs.getReader();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
