Title: [199781] trunk/Source/WebCore
- Revision
- 199781
- Author
- [email protected]
- Date
- 2016-04-20 12:57:10 -0700 (Wed, 20 Apr 2016)
Log Message
Potential overflow in RenderLayer::hitTestList()
https://bugs.webkit.org/show_bug.cgi?id=156804
Reviewed by Simon Fraser.
Use size_t type instead of int to iterate over the Vector to make sure
we don't overflow. This is a speculative fix for <rdar://problem/23249479>.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTestList):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (199780 => 199781)
--- trunk/Source/WebCore/ChangeLog 2016-04-20 19:10:43 UTC (rev 199780)
+++ trunk/Source/WebCore/ChangeLog 2016-04-20 19:57:10 UTC (rev 199781)
@@ -1,3 +1,16 @@
+2016-04-20 Chris Dumez <[email protected]>
+
+ Potential overflow in RenderLayer::hitTestList()
+ https://bugs.webkit.org/show_bug.cgi?id=156804
+
+ Reviewed by Simon Fraser.
+
+ Use size_t type instead of int to iterate over the Vector to make sure
+ we don't overflow. This is a speculative fix for <rdar://problem/23249479>.
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::hitTestList):
+
2016-04-20 Brady Eidson <[email protected]>
Modern IDB (Workers): Enable INDEXED_DATABASE_IN_WORKERS compile time flag, but disabled in RuntimeEnabledFeatures.
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (199780 => 199781)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2016-04-20 19:10:43 UTC (rev 199780)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2016-04-20 19:57:10 UTC (rev 199781)
@@ -5352,8 +5352,8 @@
return nullptr;
RenderLayer* resultLayer = nullptr;
- for (int i = list->size() - 1; i >= 0; --i) {
- RenderLayer* childLayer = list->at(i);
+ for (size_t i = list->size(); i > 0; --i) {
+ RenderLayer* childLayer = list->at(i - 1);
if (childLayer->isFlowThreadCollectingGraphicsLayersUnderRegions())
continue;
RenderLayer* hitLayer = nullptr;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
