Title: [199895] trunk
- Revision
- 199895
- Author
- [email protected]
- Date
- 2016-04-22 12:42:24 -0700 (Fri, 22 Apr 2016)
Log Message
REGRESSION (r189567): The top of Facebook's messenger.com looks visually broken
https://bugs.webkit.org/show_bug.cgi?id=156869
<rdar://problem/23204668>
Reviewed by Zalan Bujtas.
Source/WebCore:
Added fast/block/min-content-with-box-sizing.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeIntrinsicLogicalContentHeightUsing):
LayoutTests:
* fast/block/min-content-box-sizing-expected.html: Added.
* fast/block/min-content-box-sizing.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (199894 => 199895)
--- trunk/LayoutTests/ChangeLog 2016-04-22 19:27:57 UTC (rev 199894)
+++ trunk/LayoutTests/ChangeLog 2016-04-22 19:42:24 UTC (rev 199895)
@@ -1,3 +1,14 @@
+2016-04-22 Dave Hyatt <[email protected]>
+
+ REGRESSION (r189567): The top of Facebook's messenger.com looks visually broken
+ https://bugs.webkit.org/show_bug.cgi?id=156869
+ <rdar://problem/23204668>
+
+ Reviewed by Zalan Bujtas.
+
+ * fast/block/min-content-box-sizing-expected.html: Added.
+ * fast/block/min-content-box-sizing.html: Added.
+
2016-04-22 Chris Dumez <[email protected]>
Support disabling at runtime IndexedDB constructors exposed to workers
Added: trunk/LayoutTests/fast/block/min-content-box-sizing-expected.html (0 => 199895)
--- trunk/LayoutTests/fast/block/min-content-box-sizing-expected.html (rev 0)
+++ trunk/LayoutTests/fast/block/min-content-box-sizing-expected.html 2016-04-22 19:42:24 UTC (rev 199895)
@@ -0,0 +1,3 @@
+<div style="float:left; border:2px solid black; padding:10px; box-sizing:border-box;">
+<div style="width:100px;height:100px;background-color:green"></div>
+</div>
Added: trunk/LayoutTests/fast/block/min-content-box-sizing.html (0 => 199895)
--- trunk/LayoutTests/fast/block/min-content-box-sizing.html (rev 0)
+++ trunk/LayoutTests/fast/block/min-content-box-sizing.html 2016-04-22 19:42:24 UTC (rev 199895)
@@ -0,0 +1,3 @@
+<div style="float:left; border:2px solid black; padding:10px; box-sizing:border-box; height:500px; height:-webkit-min-content; height:-moz-min-content; height:min-content; width:500px; width:-webkit-min-content; width:-moz-min-content; width:min-content">
+<div style="width:100px;height:100px;background-color:green"></div>
+</div>
Modified: trunk/Source/WebCore/ChangeLog (199894 => 199895)
--- trunk/Source/WebCore/ChangeLog 2016-04-22 19:27:57 UTC (rev 199894)
+++ trunk/Source/WebCore/ChangeLog 2016-04-22 19:42:24 UTC (rev 199895)
@@ -1,3 +1,16 @@
+2016-04-22 Dave Hyatt <[email protected]>
+
+ REGRESSION (r189567): The top of Facebook's messenger.com looks visually broken
+ https://bugs.webkit.org/show_bug.cgi?id=156869
+ <rdar://problem/23204668>
+
+ Reviewed by Zalan Bujtas.
+
+ Added fast/block/min-content-with-box-sizing.html
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::computeIntrinsicLogicalContentHeightUsing):
+
2016-04-22 Antti Koivisto <[email protected]>
TextAutoSizingKey should use normal refcounting
Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (199894 => 199895)
--- trunk/Source/WebCore/rendering/RenderBox.cpp 2016-04-22 19:27:57 UTC (rev 199894)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2016-04-22 19:42:24 UTC (rev 199895)
@@ -2898,8 +2898,13 @@
{
// FIXME: The CSS sizing spec is considering changing what min-content/max-content should resolve to.
// If that happens, this code will have to change.
- if (logicalHeightLength.isMinContent() || logicalHeightLength.isMaxContent() || logicalHeightLength.isFitContent())
+ if (logicalHeightLength.isMinContent() || logicalHeightLength.isMaxContent() || logicalHeightLength.isFitContent()) {
+ if (!intrinsicContentHeight)
+ return intrinsicContentHeight;
+ if (style().boxSizing() == BORDER_BOX)
+ return intrinsicContentHeight.value() + borderAndPaddingLogicalHeight();
return intrinsicContentHeight;
+ }
if (logicalHeightLength.isFillAvailable())
return containingBlock()->availableLogicalHeight(ExcludeMarginBorderPadding) - borderAndPadding;
ASSERT_NOT_REACHED();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
