Title: [199912] trunk/Source/WebCore
Revision
199912
Author
[email protected]
Date
2016-04-22 14:48:39 -0700 (Fri, 22 Apr 2016)

Log Message

[iOS] Crash at -[WebAVPlayerLayer resolveBounds]
https://bugs.webkit.org/show_bug.cgi?id=156931
<rdar://problem/25865315>

Reviewed by Eric Carlson.

When cloning the WebAVPlayerLayer, we must copy over the fullscreenInterface to the cloned layer.

* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebAVPlayerLayerView_startRoutingVideoToPictureInPicturePlayerLayerView):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (199911 => 199912)


--- trunk/Source/WebCore/ChangeLog	2016-04-22 21:40:39 UTC (rev 199911)
+++ trunk/Source/WebCore/ChangeLog	2016-04-22 21:48:39 UTC (rev 199912)
@@ -1,3 +1,16 @@
+2016-04-22  Jer Noble  <[email protected]>
+
+        [iOS] Crash at -[WebAVPlayerLayer resolveBounds]
+        https://bugs.webkit.org/show_bug.cgi?id=156931
+        <rdar://problem/25865315> 
+
+        Reviewed by Eric Carlson.
+
+        When cloning the WebAVPlayerLayer, we must copy over the fullscreenInterface to the cloned layer.
+
+        * platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+        (WebAVPlayerLayerView_startRoutingVideoToPictureInPicturePlayerLayerView):
+
 2016-04-22  Chris Dumez  <[email protected]>
 
         Crash under WebCore::DataDetection::detectContentInRange()

Modified: trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm (199911 => 199912)


--- trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm	2016-04-22 21:40:39 UTC (rev 199911)
+++ trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm	2016-04-22 21:48:39 UTC (rev 199912)
@@ -458,6 +458,7 @@
     [pipPlayerLayer setVideoGravity:playerLayer.videoGravity];
     [pipPlayerLayer setModelVideoLayerFrame:playerLayer.modelVideoLayerFrame];
     [pipPlayerLayer setPlayerController:playerLayer.playerController];
+    [pipPlayerLayer setFullscreenInterface:playerLayer.fullscreenInterface];
     [pipView addSubview:playerLayerView.videoView];
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to