Title: [199986] trunk/Source/WebCore
Revision
199986
Author
[email protected]
Date
2016-04-25 03:26:53 -0700 (Mon, 25 Apr 2016)

Log Message

Drop [UsePointersEvenForNonNullableObjectArguments] from TextTrack
https://bugs.webkit.org/show_bug.cgi?id=156899

Reviewed by Chris Dumez.

No behavior changes.

* html/track/TextTrack.idl: Marking cue and region parameter as nullable.
Also marking cues and activeCues as nullable attributes.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (199985 => 199986)


--- trunk/Source/WebCore/ChangeLog	2016-04-25 10:23:41 UTC (rev 199985)
+++ trunk/Source/WebCore/ChangeLog	2016-04-25 10:26:53 UTC (rev 199986)
@@ -1,5 +1,17 @@
 2016-04-25  Youenn Fablet  <[email protected]>
 
+        Drop [UsePointersEvenForNonNullableObjectArguments] from TextTrack
+        https://bugs.webkit.org/show_bug.cgi?id=156899
+
+        Reviewed by Chris Dumez.
+
+        No behavior changes.
+
+        * html/track/TextTrack.idl: Marking cue and region parameter as nullable.
+        Also marking cues and activeCues as nullable attributes.
+
+2016-04-25  Youenn Fablet  <[email protected]>
+
         Drop [UsePointersEvenForNonNullableObjectArguments] from File API interfaces
         https://bugs.webkit.org/show_bug.cgi?id=156898
 

Modified: trunk/Source/WebCore/html/track/TextTrack.idl (199985 => 199986)


--- trunk/Source/WebCore/html/track/TextTrack.idl	2016-04-25 10:23:41 UTC (rev 199985)
+++ trunk/Source/WebCore/html/track/TextTrack.idl	2016-04-25 10:26:53 UTC (rev 199986)
@@ -28,7 +28,6 @@
 
 [
     Conditional=VIDEO_TRACK,
-    UsePointersEvenForNonNullableObjectArguments,
     GenerateIsReachable=ImplElementRoot,
     JSCustomMarkFunction,
     SkipVTableValidation,
@@ -41,17 +40,19 @@
 
     attribute TextTrackMode mode;
 
-    readonly attribute TextTrackCueList cues;
-    readonly attribute TextTrackCueList activeCues;
+    readonly attribute TextTrackCueList? cues;
+    readonly attribute TextTrackCueList? activeCues;
 
-    [RaisesException] void addCue(TextTrackCue cue);
-    [RaisesException] void removeCue(TextTrackCue cue);
+    // FIXME: cue parameter should not be nullable in addCue and removeCue.
+    [RaisesException] void addCue(TextTrackCue? cue);
+    [RaisesException] void removeCue(TextTrackCue? cue);
 
     attribute EventHandler oncuechange;
 
 #if !defined(LANGUAGE_GOBJECT) || !LANGUAGE_GOBJECT // Work around shortcomings in the gobject binding generator handling of conditional features by turning these off for gobject.
     readonly attribute VTTRegionList regions;
-    void addRegion(VTTRegion region);
-    [RaisesException] void removeRegion(VTTRegion region);
+    // FIXME: region parameter should not be nullable in addRegion and removeRegion.
+    void addRegion(VTTRegion? region);
+    [RaisesException] void removeRegion(VTTRegion? region);
 #endif
 };
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to