Title: [200014] releases/WebKitGTK/webkit-2.12/Tools
- Revision
- 200014
- Author
- [email protected]
- Date
- 2016-04-25 08:23:48 -0700 (Mon, 25 Apr 2016)
Log Message
Merge r199653 - [GTK] Test /webkit2/WebKitWebView/mouse-target fails with overlay scrollbars
https://bugs.webkit.org/show_bug.cgi?id=156621
Reviewed by Martin Robinson.
This is a problem of the test itself, we are using an overflow that is not actually scrollable, but that shows
scrollbar troughs when not using overlay scrollbars because it's marked as scrollable. It would be easier to
simply use the main frame scrollbars to test that and it will work no matter of scrollbars are overlay or not.
* TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
(testWebViewMouseTarget): Remove the div and move the mouse over the main frame scrollbar to test scrolbars hit test.
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.12/Tools/ChangeLog (200013 => 200014)
--- releases/WebKitGTK/webkit-2.12/Tools/ChangeLog 2016-04-25 15:15:25 UTC (rev 200013)
+++ releases/WebKitGTK/webkit-2.12/Tools/ChangeLog 2016-04-25 15:23:48 UTC (rev 200014)
@@ -1,3 +1,17 @@
+2016-04-18 Carlos Garcia Campos <[email protected]>
+
+ [GTK] Test /webkit2/WebKitWebView/mouse-target fails with overlay scrollbars
+ https://bugs.webkit.org/show_bug.cgi?id=156621
+
+ Reviewed by Martin Robinson.
+
+ This is a problem of the test itself, we are using an overflow that is not actually scrollable, but that shows
+ scrollbar troughs when not using overlay scrollbars because it's marked as scrollable. It would be easier to
+ simply use the main frame scrollbars to test that and it will work no matter of scrollbars are overlay or not.
+
+ * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
+ (testWebViewMouseTarget): Remove the div and move the mouse over the main frame scrollbar to test scrolbars hit test.
+
2016-04-05 Simon Fraser <[email protected]>
Implement operator== and operator!= for Optional<>
Modified: releases/WebKitGTK/webkit-2.12/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp (200013 => 200014)
--- releases/WebKitGTK/webkit-2.12/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp 2016-04-25 15:15:25 UTC (rev 200013)
+++ releases/WebKitGTK/webkit-2.12/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp 2016-04-25 15:23:48 UTC (rev 200014)
@@ -614,7 +614,6 @@
" <img style='position:absolute; left:1; top:10' src='' width=5 height=5></img>"
" <a style='position:absolute; left:1; top:20' href='' title='WebKitGTK+ Logo'><img src='' width=5 height=5></img></a>"
" <input style='position:absolute; left:1; top:30' size='10'></input>"
- " <div style='position:absolute; left:1; top:50; width:30; height:30; overflow:scroll'> </div>"
" <video style='position:absolute; left:1; top:100' width='300' height='300' controls='controls' preload='none'><source src='' type='video/ogg' /></video>"
" <p style='position:absolute; left:1; top:120' id='text_to_select'>Lorem ipsum.</p>"
"</body></html>";
@@ -690,7 +689,7 @@
g_assert(!test->m_mouseTargetModifiers);
// Move over scrollbar.
- hitTestResult = test->moveMouseAndWaitUntilMouseTargetChanged(5, 75);
+ hitTestResult = test->moveMouseAndWaitUntilMouseTargetChanged(gtk_widget_get_allocated_width(GTK_WIDGET(test->m_webView)) - 4, 5);
g_assert(!webkit_hit_test_result_context_is_link(hitTestResult));
g_assert(!webkit_hit_test_result_context_is_image(hitTestResult));
g_assert(!webkit_hit_test_result_context_is_media(hitTestResult));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
