Title: [200021] releases/WebKitGTK/webkit-2.12
- Revision
- 200021
- Author
- [email protected]
- Date
- 2016-04-25 08:46:41 -0700 (Mon, 25 Apr 2016)
Log Message
Merge r199715 - [GTK] accessibility/gtk/entry-and-password.html is failing since r194847
https://bugs.webkit.org/show_bug.cgi?id=153062
Reviewed by Carlos Garcia Campos.
Source/WebCore:
The changes in r194847 include using WebCore's rendering for the CapsLock indicator.
As a side effect, password inputs gained a TextControlInnerTextElement child from
the Shadow DOM. If we include that child in the accessibility tree, the child will
emit focus and text notifications that suggest the user is no longer in the control.
This can be especially problematic for screen reader users with key echo enabled
when typing in a password input. To fix this, prune TextControlInnerTextElement
children from the accessibility tree for ATK.
No new tests as existing coverage caught this regression. Also modified the
auto-fill-crash.html test whose expectations include the children count for
a text input.
* accessibility/atk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
LayoutTests:
The auto-fill-crash.html test has expectations which include the children
count for the text input. These expectations were incorrect for ATK where
accessible text inputs lack accessible text children.
* accessibility/auto-fill-crash.html: Modified to take platform into account.
* platform/gtk/TestExpectations: Unskipped entry-and-password.html.
* platform/gtk/accessibility/auto-fill-crash-expected.txt: Added.
Modified Paths
Added Paths
Diff
Modified: releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog (200020 => 200021)
--- releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog 2016-04-25 15:41:32 UTC (rev 200020)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog 2016-04-25 15:46:41 UTC (rev 200021)
@@ -1,3 +1,18 @@
+2016-04-19 Joanmarie Diggs <[email protected]>
+
+ [GTK] accessibility/gtk/entry-and-password.html is failing since r194847
+ https://bugs.webkit.org/show_bug.cgi?id=153062
+
+ Reviewed by Carlos Garcia Campos.
+
+ The auto-fill-crash.html test has expectations which include the children
+ count for the text input. These expectations were incorrect for ATK where
+ accessible text inputs lack accessible text children.
+
+ * accessibility/auto-fill-crash.html: Modified to take platform into account.
+ * platform/gtk/TestExpectations: Unskipped entry-and-password.html.
+ * platform/gtk/accessibility/auto-fill-crash-expected.txt: Added.
+
2016-04-18 Martin Robinson <[email protected]>
[GTK] Possible off-by-one in hyphenation code
Modified: releases/WebKitGTK/webkit-2.12/LayoutTests/platform/gtk/TestExpectations (200020 => 200021)
--- releases/WebKitGTK/webkit-2.12/LayoutTests/platform/gtk/TestExpectations 2016-04-25 15:41:32 UTC (rev 200020)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/platform/gtk/TestExpectations 2016-04-25 15:46:41 UTC (rev 200021)
@@ -2600,8 +2600,6 @@
webkit.org/b/152908 pageoverlay/overlay-small-frame-mouse-events.html [ Failure ]
webkit.org/b/152908 pageoverlay/overlay-small-frame-paints.html [ Failure ]
-webkit.org/b/153062 accessibility/gtk/entry-and-password.html [ Failure ]
-
webkit.org/b/153602 fast/table/003.html [ Failure ]
webkit.org/b/153602 fast/text/emoji.html [ Failure ]
webkit.org/b/153602 tables/mozilla_expected_failures/bugs/bug89315.html [ Failure ]
Added: releases/WebKitGTK/webkit-2.12/LayoutTests/platform/gtk/accessibility/auto-fill-crash-expected.txt (0 => 200021)
--- releases/WebKitGTK/webkit-2.12/LayoutTests/platform/gtk/accessibility/auto-fill-crash-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/platform/gtk/accessibility/auto-fill-crash-expected.txt 2016-04-25 15:46:41 UTC (rev 200021)
@@ -0,0 +1,12 @@
+
+This tests that when an auto fill element is removed we won't crash accessing an old value.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS accessibilityController.accessibleElementById('textfield').childrenCount is 2
+PASS accessibilityController.accessibleElementById('textfield').childrenCount is 0
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog (200020 => 200021)
--- releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog 2016-04-25 15:41:32 UTC (rev 200020)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog 2016-04-25 15:46:41 UTC (rev 200021)
@@ -1,3 +1,25 @@
+2016-04-19 Joanmarie Diggs <[email protected]>
+
+ [GTK] accessibility/gtk/entry-and-password.html is failing since r194847
+ https://bugs.webkit.org/show_bug.cgi?id=153062
+
+ Reviewed by Carlos Garcia Campos.
+
+ The changes in r194847 include using WebCore's rendering for the CapsLock indicator.
+ As a side effect, password inputs gained a TextControlInnerTextElement child from
+ the Shadow DOM. If we include that child in the accessibility tree, the child will
+ emit focus and text notifications that suggest the user is no longer in the control.
+ This can be especially problematic for screen reader users with key echo enabled
+ when typing in a password input. To fix this, prune TextControlInnerTextElement
+ children from the accessibility tree for ATK.
+
+ No new tests as existing coverage caught this regression. Also modified the
+ auto-fill-crash.html test whose expectations include the children count for
+ a text input.
+
+ * accessibility/atk/AccessibilityObjectAtk.cpp:
+ (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
+
2016-04-18 Martin Robinson <[email protected]>
[GTK] Possible off-by-one in hyphenation code
Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/accessibility/atk/AccessibilityObjectAtk.cpp (200020 => 200021)
--- releases/WebKitGTK/webkit-2.12/Source/WebCore/accessibility/atk/AccessibilityObjectAtk.cpp 2016-04-25 15:41:32 UTC (rev 200020)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/accessibility/atk/AccessibilityObjectAtk.cpp 2016-04-25 15:46:41 UTC (rev 200021)
@@ -24,6 +24,7 @@
#include "HTMLElement.h"
#include "HTMLNames.h"
#include "RenderText.h"
+#include "TextControlInnerElements.h"
#include <glib-object.h>
#if HAVE(ACCESSIBILITY)
@@ -96,6 +97,13 @@
if (node && node->hasTagName(HTMLNames::spanTag) && !canSetFocusAttribute() && !hasAttributesRequiredForInclusion())
return IgnoreObject;
+ // If we include TextControlInnerTextElement children, changes to those children
+ // will result in focus and text notifications that suggest the user is no longer
+ // in the control. This can be especially problematic for screen reader users with
+ // key echo enabled when typing in a password input.
+ if (is<TextControlInnerTextElement>(node))
+ return IgnoreObject;
+
// Given a paragraph or div containing a non-nested anonymous block, WebCore
// ignores the paragraph or div and includes the block. We want the opposite:
// ATs are expecting accessible objects associated with textual elements. They
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
