Title: [200078] trunk
- Revision
- 200078
- Author
- [email protected]
- Date
- 2016-04-26 06:03:13 -0700 (Tue, 26 Apr 2016)
Log Message
Drop [UsePointersEvenForNonNullableObjectArguments] from EventTarget
https://bugs.webkit.org/show_bug.cgi?id=156977
Reviewed by Chris Dumez.
Source/WebCore:
No change of behavior.
* dom/EventTarget.idl:
LayoutTests:
* fast/events/dispatchEvent-crash-expected.txt:
* fast/events/dispatchEvent-crash.html: Ensuring exceptions are logged.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (200077 => 200078)
--- trunk/LayoutTests/ChangeLog 2016-04-26 08:16:24 UTC (rev 200077)
+++ trunk/LayoutTests/ChangeLog 2016-04-26 13:03:13 UTC (rev 200078)
@@ -1,3 +1,13 @@
+2016-04-26 Youenn Fablet <[email protected]>
+
+ Drop [UsePointersEvenForNonNullableObjectArguments] from EventTarget
+ https://bugs.webkit.org/show_bug.cgi?id=156977
+
+ Reviewed by Chris Dumez.
+
+ * fast/events/dispatchEvent-crash-expected.txt:
+ * fast/events/dispatchEvent-crash.html: Ensuring exceptions are logged.
+
2016-04-25 Ryosuke Niwa <[email protected]>
Update template element tests
Modified: trunk/LayoutTests/fast/events/dispatchEvent-crash-expected.txt (200077 => 200078)
--- trunk/LayoutTests/fast/events/dispatchEvent-crash-expected.txt 2016-04-26 08:16:24 UTC (rev 200077)
+++ trunk/LayoutTests/fast/events/dispatchEvent-crash-expected.txt 2016-04-26 13:03:13 UTC (rev 200078)
@@ -1 +1,28 @@
This is a test for https://bugs.webkit.org/show_bug.cgi?id=21063 (NULL pointer crash in dispatchEvent(null)). It passes if it does not crash.
+
+Exception thrown for null: TypeError: Type error
+Exception thrown for undefined: TypeError: Type error
+Exception thrown for string: TypeError: Type error
+Exception thrown for 0: TypeError: Type error
+Exception thrown for object: TypeError: Type error
+Exception thrown for null: TypeError: Type error
+Exception thrown for undefined: TypeError: Type error
+Exception thrown for string: TypeError: Type error
+Exception thrown for 0: TypeError: Type error
+Exception thrown for object: TypeError: Type error
+Exception thrown for null: TypeError: Type error
+Exception thrown for undefined: TypeError: Type error
+Exception thrown for string: TypeError: Type error
+Exception thrown for 0: TypeError: Type error
+Exception thrown for object: TypeError: Type error
+Exception thrown for null: TypeError: Type error
+Exception thrown for undefined: TypeError: Type error
+Exception thrown for string: TypeError: Type error
+Exception thrown for 0: TypeError: Type error
+Exception thrown for object: TypeError: Type error
+Exception thrown for null: TypeError: Type error
+Exception thrown for undefined: TypeError: Type error
+Exception thrown for string: TypeError: Type error
+Exception thrown for 0: TypeError: Type error
+Exception thrown for object: TypeError: Type error
+
Modified: trunk/LayoutTests/fast/events/dispatchEvent-crash.html (200077 => 200078)
--- trunk/LayoutTests/fast/events/dispatchEvent-crash.html 2016-04-26 08:16:24 UTC (rev 200077)
+++ trunk/LayoutTests/fast/events/dispatchEvent-crash.html 2016-04-26 13:03:13 UTC (rev 200078)
@@ -1,5 +1,10 @@
<p>This is a test for https://bugs.webkit.org/show_bug.cgi?id=21063 (NULL pointer crash in dispatchEvent(null)). It passes if it does not crash.</p>
+<div id="log"></div>
<script>
+ function log(message) {
+ document.getElementById("log").innerHTML += message + "<br>";
+ }
+
if (window.testRunner)
testRunner.dumpAsText();
@@ -11,26 +16,31 @@
try {
eventTarget.dispatchEvent(null);
} catch(e) {
+ log("Exception thrown for null: " + e);
}
try {
eventTarget.dispatchEvent(undefined);
} catch(e) {
+ log("Exception thrown for undefined: " + e);
}
try {
eventTarget.dispatchEvent("string");
} catch(e) {
+ log("Exception thrown for string: " + e);
}
try {
eventTarget.dispatchEvent(0);
} catch(e) {
+ log("Exception thrown for 0: " + e);
}
try {
eventTarget.dispatchEvent({});
} catch(e) {
+ log("Exception thrown for object: " + e);
}
}
</script>
Modified: trunk/Source/WebCore/ChangeLog (200077 => 200078)
--- trunk/Source/WebCore/ChangeLog 2016-04-26 08:16:24 UTC (rev 200077)
+++ trunk/Source/WebCore/ChangeLog 2016-04-26 13:03:13 UTC (rev 200078)
@@ -1,3 +1,14 @@
+2016-04-26 Youenn Fablet <[email protected]>
+
+ Drop [UsePointersEvenForNonNullableObjectArguments] from EventTarget
+ https://bugs.webkit.org/show_bug.cgi?id=156977
+
+ Reviewed by Chris Dumez.
+
+ No change of behavior.
+
+ * dom/EventTarget.idl:
+
2016-04-25 Ryosuke Niwa <[email protected]>
Remove the build flag for template elements
Modified: trunk/Source/WebCore/dom/EventTarget.idl (200077 => 200078)
--- trunk/Source/WebCore/dom/EventTarget.idl 2016-04-26 08:16:24 UTC (rev 200077)
+++ trunk/Source/WebCore/dom/EventTarget.idl 2016-04-26 13:03:13 UTC (rev 200078)
@@ -21,12 +21,12 @@
// Introduced in DOM Level 2:
[
CustomToJSObject,
- UsePointersEvenForNonNullableObjectArguments,
+ JSCustomHeader,
JSCustomToNativeObject,
- JSCustomHeader,
ObjCProtocol,
] interface EventTarget {
- [ObjCLegacyUnnamedParameters] void addEventListener(DOMString type, EventListener listener, optional boolean useCapture = false);
- [ObjCLegacyUnnamedParameters] void removeEventListener(DOMString type, EventListener listener, optional boolean useCapture = false);
- [ImplementedAs=dispatchEventForBindings, RaisesException] boolean dispatchEvent(Event event);
+ [ObjCLegacyUnnamedParameters] void addEventListener(DOMString type, EventListener? listener, optional boolean useCapture = false);
+ [ObjCLegacyUnnamedParameters] void removeEventListener(DOMString type, EventListener? listener, optional boolean useCapture = false);
+ // FIXME: event should not be nullable.
+ [ImplementedAs=dispatchEventForBindings, RaisesException] boolean dispatchEvent(Event? event);
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
