Title: [200139] trunk/Source/_javascript_Core
Revision
200139
Author
[email protected]
Date
2016-04-27 12:00:22 -0700 (Wed, 27 Apr 2016)

Log Message

Address feedback from https://bugs.webkit.org/show_bug.cgi?id=157048#c5.
https://bugs.webkit.org/show_bug.cgi?id=157096

Reviewed by Geoffrey Garen.

1. Check for USE(APPLE_INTERNAL_SDK) instead of __has_include(<mach-o/dyld_priv.h>).
2. Rename webkitFirstSDKVersionWithInitConstructorSupport to
   firstSDKVersionWithInitConstructorSupport.

* API/JSWrapperMap.mm:
(supportsInitMethodConstructors):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/API/JSWrapperMap.mm (200138 => 200139)


--- trunk/Source/_javascript_Core/API/JSWrapperMap.mm	2016-04-27 18:59:52 UTC (rev 200138)
+++ trunk/Source/_javascript_Core/API/JSWrapperMap.mm	2016-04-27 19:00:22 UTC (rev 200139)
@@ -44,16 +44,16 @@
 
 #include <mach-o/dyld.h>
 
-#if __has_include(<mach-o/dyld_priv.h>)
+#if USE(APPLE_INTERNAL_SDK)
 #include <mach-o/dyld_priv.h>
 #endif
 extern "C" uint32_t dyld_get_program_sdk_version();
 
 #if PLATFORM(APPLETV)
 #elif PLATFORM(IOS)
-static const uint32_t webkitFirstSDKVersionWithInitConstructorSupport = 0x80000; // iOS 8.0.0
+static const uint32_t firstSDKVersionWithInitConstructorSupport = 0x80000; // iOS 8.0.0
 #elif PLATFORM(MAC)
-static const uint32_t webkitFirstSDKVersionWithInitConstructorSupport = 0xA0A00; // OSX 10.10.0
+static const uint32_t firstSDKVersionWithInitConstructorSupport = 0xA0A00; // OSX 10.10.0
 #endif
 
 @class JSObjCClassInfo;
@@ -664,7 +664,7 @@
     static uint32_t programSDKVersion = 0;
     if (!programSDKVersion)
         programSDKVersion = dyld_get_program_sdk_version();
-    return programSDKVersion >= webkitFirstSDKVersionWithInitConstructorSupport;
+    return programSDKVersion >= firstSDKVersionWithInitConstructorSupport;
 #endif
 }
 

Modified: trunk/Source/_javascript_Core/ChangeLog (200138 => 200139)


--- trunk/Source/_javascript_Core/ChangeLog	2016-04-27 18:59:52 UTC (rev 200138)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-04-27 19:00:22 UTC (rev 200139)
@@ -1,5 +1,19 @@
 2016-04-27  Mark Lam  <[email protected]>
 
+        Address feedback from https://bugs.webkit.org/show_bug.cgi?id=157048#c5.
+        https://bugs.webkit.org/show_bug.cgi?id=157096
+
+        Reviewed by Geoffrey Garen.
+
+        1. Check for USE(APPLE_INTERNAL_SDK) instead of __has_include(<mach-o/dyld_priv.h>).
+        2. Rename webkitFirstSDKVersionWithInitConstructorSupport to
+           firstSDKVersionWithInitConstructorSupport.
+
+        * API/JSWrapperMap.mm:
+        (supportsInitMethodConstructors):
+
+2016-04-27  Mark Lam  <[email protected]>
+
         Restrict the availability of some JSC options to local debug builds only.
         https://bugs.webkit.org/show_bug.cgi?id=157058
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to