Title: [200150] trunk/Source/WebCore
- Revision
- 200150
- Author
- [email protected]
- Date
- 2016-04-27 14:07:06 -0700 (Wed, 27 Apr 2016)
Log Message
Clean up Font::removeFromSystemFallbackCache()
https://bugs.webkit.org/show_bug.cgi?id=157093
Reviewed by Darin Adler.
Fonts have a bit which represents whether or not the system fallback cache references them.
This bit gets set to 1 when they are inserted into the system fallback cache, but was not
being reset back to 0 when it was removed.
This is benign, since the old codepath has no effect. However, we can speed up the function
by properly updating this bit.
No new tests because there is no behavior change.
* platform/graphics/Font.cpp:
(WebCore::Font::removeFromSystemFallbackCache):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (200149 => 200150)
--- trunk/Source/WebCore/ChangeLog 2016-04-27 20:54:37 UTC (rev 200149)
+++ trunk/Source/WebCore/ChangeLog 2016-04-27 21:07:06 UTC (rev 200150)
@@ -1,3 +1,22 @@
+2016-04-27 Myles C. Maxfield <[email protected]>
+
+ Clean up Font::removeFromSystemFallbackCache()
+ https://bugs.webkit.org/show_bug.cgi?id=157093
+
+ Reviewed by Darin Adler.
+
+ Fonts have a bit which represents whether or not the system fallback cache references them.
+ This bit gets set to 1 when they are inserted into the system fallback cache, but was not
+ being reset back to 0 when it was removed.
+
+ This is benign, since the old codepath has no effect. However, we can speed up the function
+ by properly updating this bit.
+
+ No new tests because there is no behavior change.
+
+ * platform/graphics/Font.cpp:
+ (WebCore::Font::removeFromSystemFallbackCache):
+
2016-04-27 Adam Bergkvist <[email protected]>
WebRTC: RTCIceCandidate don't need a custom bindings
Modified: trunk/Source/WebCore/platform/graphics/Font.cpp (200149 => 200150)
--- trunk/Source/WebCore/platform/graphics/Font.cpp 2016-04-27 20:54:37 UTC (rev 200149)
+++ trunk/Source/WebCore/platform/graphics/Font.cpp 2016-04-27 21:07:06 UTC (rev 200150)
@@ -477,11 +477,12 @@
void Font::removeFromSystemFallbackCache()
{
- systemFallbackCache().remove(this);
-
if (!m_isUsedInSystemFallbackCache)
return;
+ m_isUsedInSystemFallbackCache = false;
+ systemFallbackCache().remove(this);
+
for (auto& characterMap : systemFallbackCache().values()) {
Vector<CharacterFallbackMapKey, 512> toRemove;
for (auto& entry : characterMap) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
