Title: [200175] trunk/Tools
- Revision
- 200175
- Author
- [email protected]
- Date
- 2016-04-27 23:46:49 -0700 (Wed, 27 Apr 2016)
Log Message
Don't throttle GuardMalloc on 8-core Macs
https://bugs.webkit.org/show_bug.cgi?id=157108
Reviewed by Alex Christensen.
This was making them slower unnecessarily.
* Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (200174 => 200175)
--- trunk/Tools/ChangeLog 2016-04-28 06:23:23 UTC (rev 200174)
+++ trunk/Tools/ChangeLog 2016-04-28 06:46:49 UTC (rev 200175)
@@ -1,3 +1,14 @@
+2016-04-27 Alexey Proskuryakov <[email protected]>
+
+ Don't throttle GuardMalloc on 8-core Macs
+ https://bugs.webkit.org/show_bug.cgi?id=157108
+
+ Reviewed by Alex Christensen.
+
+ This was making them slower unnecessarily.
+
+ * Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):
+
2016-04-26 Konstantin Tokarev <[email protected]>
Unreviewed: add myself to the committers list.
Modified: trunk/Tools/Scripts/webkitpy/port/mac.py (200174 => 200175)
--- trunk/Tools/Scripts/webkitpy/port/mac.py 2016-04-28 06:23:23 UTC (rev 200174)
+++ trunk/Tools/Scripts/webkitpy/port/mac.py 2016-04-28 06:46:49 UTC (rev 200175)
@@ -155,13 +155,13 @@
should_throttle_for_wk2 = self.get_option('webkit_test_runner') and default_count > 4
# We also want to throttle for leaks bots.
if should_throttle_for_wk2 or self.get_option('leaks'):
- if self.get_option('guard_malloc'):
- # Some 12 core Macs get a lot of tests time out when running 18 WebKitTestRunner processes (it's not clear what this depends on).
- # Running 12 processes resolves this, and doesn't seem to introduce a measurable performance degradation on other machines.
- default_count = int(.5 * default_count)
- else:
- default_count = int(.75 * default_count)
+ default_count = int(.75 * default_count)
+ if should_throttle_for_wk2 and self.get_option('guard_malloc'):
+ # Some 12 core Macs get a lot of tests time out when running 18 WebKitTestRunner processes (it's not clear what this depends on).
+ # <rdar://problem/25750302>
+ default_count = min(default_count, 12)
+
# Make sure we have enough ram to support that many instances:
total_memory = self.host.platform.total_bytes_memory()
if total_memory:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
