On Feb 16, 2007, at 10:49 PM, Morgan L wrote:
I was wondering if there are any plans to replace FrameLoaderClient::dispatchCreatePage with a call to ChromeClient::createWindow. It seems like FrameLoader::createWindow already calls ChromeClient::CreateWindow, and FrameLoaderClient::dispatchCreatePage is somewhat duplicating ChromeClient::createWindow. Thoughts? Would a patch along these lines be welcomed?
You are right. The FrameLoaderClient call should be removed and the ChromeClient one should be used instead. There is no reason for them to be separate besides oversight, as far as I can tell.
Regards, Maciej _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo/webkit-dev
