On Aug 19, 2007, at 9:08 AM, David D. Kilzer wrote:

Hi David,

I would guess that you should start looking in RenderObject::paintBoxShadow() and RenderObject::drawBorderArc(), although I'm not a rendering expert. (Maybe
I will be after reading Hyatt's blog postings!)

paintBoxShadow is likely the only place that would need to change. But it looks to me like the code there is already trying to handle the border-radius case:

    if (s->hasBorderRadius()) {
        IntSize topLeft = begin ? s->borderTopLeftRadius() : IntSize();
        IntSize topRight = end ? s->borderTopRightRadius() : IntSize();
IntSize bottomLeft = begin ? s->borderBottomLeftRadius() : IntSize(); IntSize bottomRight = end ? s->borderBottomRightRadius() : IntSize(); context->clipOutRoundedRect(rect, topLeft, topRight, bottomLeft, bottomRight); context->fillRoundedRect(rect, topLeft, topRight, bottomLeft, bottomRight, Color::black);

This code looks like it should work, I'm not sure why it doesn't.



Also, if you're going to submit patches through the open source project, please consider filing a Bugzilla bug at <http://bugs.webkit.org/>. If there is a matching Radar for a bug, note that in a bug comment and add the "InRadar"
keyword.  Thanks!


David den Boer <[EMAIL PROTECTED]> wrote:

So I want to take a dip into the wekit render code for the first
time, mostly for my own knowledge, and also to fix the bug below :


That is a div with a border-radius and a drop shadow, and it does not
work properly. There is another border-radius bug I found with
background colors too, and I feel that they  are close to the same

Can someone point me to the correct area of code to start investigating?


webkit-dev mailing list

webkit-dev mailing list

Reply via email to