Marc-Antoine Ruel wrote:
Hi Alp,

About bug 16095 <http://bugs.webkit.org/show_bug.cgi?id=16095>, you wrote:

...
GraphicsContext::GraphicsContext(PlatformGraphicsContext* context)
    : m_common(createGraphicsContextPrivate())
    , m_data(new GraphicsContextPlatformPrivate)

---

What this patch intends to do is to remove the need of m_data (at least for most platforms) since the constructor could implement a subclass of GraphicsContextPrivate (not GraphicsContext!), set the pointer in m_common and not need a second memory allocation (m_data).

I think this is a good idea but it might be worthwhile to eliminate m_data completely or otherwise mark it as deprecated. Having two ways of storing data associated with a graphics context will confuse porters.
_______________________________________________
webkit-dev mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-dev

Reply via email to