On Oct 8, 2008, at 9:18 AM, Darin Adler wrote: > Hi folks. > > After a few queries from Google folks I made some minor revisions to > the RefPtr document <http://webkit.org/coding/RefPtr.html> that I > wrote a year and half ago. > > If you want to understand how to use RefPtr, PassRefPtr, and > RefCounted, and why they exist, this document is probably a good place > to start. > > Please take a look and let me know if you have any comments or ideas > for it.
I've always loved this document, and I love the new and improved version even more. One small comment: some of the examples show practices that we would not recommend inside WebKit code (or what I would judgmentally call "wrong"). Things like using raw pointers with manual refcounting, or using PassRefPtr local variables, or the like. It might be nice to visually distinguish the "good" and "bad" examples somwhow, so it's easier to tell at a glance which are the good examples to follow. Regards, Maciej _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

