On Jul 10, 2009, at 11:59 AM, Simon Fraser wrote:

On Jul 10, 2009, at 8:46 AM, Adam Roben wrote:


On Jul 8, 2009, at 6:58 PM, m...@apple.com wrote:

+ print ("-- Please remember to include a detailed description in your ChangeLog entry. --\n-- See <http://webkit.org/coding/contributing.html > for more info --\n");


Is this line supposed to end up in the ChangeLog? If so, it needs to be "print CHANGE_LOG", not just "print".

I believe the intent is to have this print in the terminal.

In that case it should be printed to STDERR. As currently coded, these lines end up in the diff that is output when you use the -d option.

Filed <https://bugs.webkit.org/show_bug.cgi?id=27150>.

-Adam

_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Reply via email to