That's why I started this thread. The process may be a bit unfamiliar to somepatch contributors (especially new ones), and so I wanted reviewers to be in the know that changes to ChromiumBridge.h should not be committed using the commit queue.
-Darin On Sat, Sep 5, 2009 at 1:45 AM, Eric Seidel <[email protected]> wrote: > Agreed. It's the submitters responsibility to make it clear that they > don't want their patch committed immediately after review. Current > assumption is that all committers don't want their patches committed after > review, but all non-committers do. > -eric > > > On Fri, Sep 4, 2009 at 7:12 PM, David Levin <[email protected]> wrote: > >> Even better if the person submitting the patch marks it as commit-queue- >> when they do the r? (as Jian does for example) to prevent this from >> happening. >> Just do this for any patch that you want to be in control of landing. >> >> dave >> >> On Fri, Sep 4, 2009 at 11:04 AM, Darin Fisher <[email protected]> wrote: >> >>> Please do not commit-queue+ changes to ChromiumBridge.h >>> These changes by definition break the Chromium build because they require >>> corresponding changes in the Chromium repository. Please leave such CLs to a >>> Chromium developer to commit because they can then coordinate the landing of >>> the other side of the patch. >>> >>> Also, if you are wondering about the impact of a WebKit patch on the >>> Chromium build, please see our integration bots here: >>> http://tinyurl.com/md47pk >>> >>> Thanks! >>> -Darin >>> >>> _______________________________________________ >>> webkit-dev mailing list >>> [email protected] >>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >>> >>> >> >> _______________________________________________ >> webkit-dev mailing list >> [email protected] >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> >> >
_______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
