On Sep 15, 2009, at 11:39 PM, cfleiz...@apple.com wrote:

+ This test should only be for Mac, since the other platforms don't support the necessary features.
+
+ WAI-ARIA: add support for ranges, including the progressbar, slider, and spinbutton roles
+        https://bugs.webkit.org/show_bug.cgi?id=28841
+
+ * accessibility/aria-slider-value-change-expected.txt: Removed.
+        * accessibility/aria-slider-value-change.html: Removed.
+ * platform/mac/accessibility/aria-slider-value-change- expected.txt: Copied from LayoutTests/accessibility/aria-slider- value-change-expected.txt. + * platform/mac/accessibility/aria-slider-value-change.html: Copied from LayoutTests/accessibility/aria-slider-value-change.html.

Is the test intrinsically Mac-only? Or is it just that Mac is the only platform that will currently pass the test?

If it's the former, moving the test to platform/mac (like you did) is the right thing. If it's the latter, then either the test should be added to the Skipped files for all the other platforms, or failing results should be checked in for all the other platforms. (I'm not sure which strategy we prefer these days.)

-Adam

_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Reply via email to