On Oct 20, 2009, at 12:50 PM, Adam Barth wrote:
The usual WebKit policy is not to accept functional changes without regression tests. I'd like to ask that this policy be enforced strictly for FrameLoader. For example, I don't think we should be taking changes like this without tests: https://bugs.webkit.org/show_bug.cgi?id=30573 This policy is going to block fixing some FrameLoader bugs until we creating a better loading test harness, but I think the long-term benefits will out-weigh the short term costs.
To clarify, we haven't been 100% strict about this in the past for areas of the code where we don't have the proper test infrastructure. That being said, it's probably time to build more infrastructure for testing page loading properly. Also, back/forward specifically can already be tested in DumpRenderTree, albeit somewhat awkwardly (assuming the symptom of this bug will manifest just by going back and forward).
- Maciej _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
