On 2009-12-02, at 21:00, Peter Kasting wrote: > I find this tricky to read and error-prone. I propose that the rule be > modified to be: > > * When all arms of a conditional or loop are one physical line, do not use > braces. If any arms are more than one physical line (even if they are one > logical line), use braces on all arms.
I do not agree that this would be an improvement. > In most places this will not differ from the existing code, so it will not > "cause the whole codebase to become invalid"; I glanced briefly at three files: RenderObject.cpp, Element.cpp and Node.cpp. In these three files I counted over two dozen places that would require modification to conform with this new rule. That's by no means a majority of the relevant statements in these files, but it's not a small number either. - Mark
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
