On Wed, Dec 30, 2009 at 2:33 PM, Sam Weinig <[email protected]> wrote: > I would prefer we stick with the run prefix. > I am also not sure why we would have separate testing scripts based by > language.
Thanks, Sam. The language-specific scripts are more an artifact of the fact that the Perl test harness is written in Perl and the Python test harness is written in Python. They can be viewed as intermediate implementation steps. With the exception of a script for testing interpreted code (as Adam suggested in an earlier e-mail), I do agree with you that contributors shouldn't have to call or know about the language-specific scripts. I submitted a patch to that effect here: https://bugs.webkit.org/show_bug.cgi?id=33045 >From an implementation perspective though, I do think they can provide a useful layer of encapsulation when calling from other code. As I mentioned in an earlier e-mail, over time we can move the language-specific scripts to a sub-folder so they won't be as visible to the end user. > If the number of these scripts got > out of hand, we could always add a run-all-tests scripts which ran them all. I think the intention is not to expose at the top level a separate script for every component, but to provide only higher-level commands. But yes, an "all" script is good. As for your preference regarding the "run" prefix, I elaborated on my reasons in the comments to the bug report. If you want, we can continue the discussion there. Thanks a lot, --Chris _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
