It sounds like no one wants this (passionately) as part of the WebKit style, so I put up a patch to remove this warning (and I won't add that text to the WebKit style guide when I modify it).
https://bugs.webkit.org/show_bug.cgi?id=33214 Dave On Mon, Jan 4, 2010 at 4:02 PM, Dirk Schulze <vb...@gmx.de> wrote: > We have somtimes constructs like > > #endif // ENABLE(SVG) > #endif // Foo_h > > It just helps to understand why there are two endif's and what they are > good for. I think it's not a style issue not to write this comment, but > it can be helpful. > > -Dirk > > Am Montag, den 04.01.2010, 15:41 -0800 schrieb Darin Adler: > > On Jan 4, 2010, at 3:33 PM, Darin Fisher wrote: > > > > > I noticed recently that the style bot started complaining about header > files ending with "#endif" instead of "#endif // Foo_h". I was surprised by > this since the style guide does not require it. > > > > I personally see little value in this sort of comment at the end of a > header file. I’m not sure what kind of problem it’s supposed to prevent. > > > > -- Darin > > > > _______________________________________________ > > webkit-dev mailing list > > webkit-dev@lists.webkit.org > > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev