On Fri, Feb 26, 2010 at 12:03 AM, Oliver Hunt <oli...@apple.com> wrote:

> But any regressions would have been blamed on eric.
>

His name would show up in the SVN log, sure, but I don't think that'd fool
your average WebKit developer for long.

webkit-patch land does the correct thing, but i disable the testing prior to
> commit because a 25 minute delay prior to committing is more or less
> guaranteed to cause it to fail to commit due to someone else landing.
>

Did you run the layout tests at all?  I generally land with --no-build as
well, but only after it's successfully passed at least one build + run of
the layout tests.


> On Feb 25, 2010, at 2:58 PM, Kenneth Russell wrote:
>
>  OK, thanks, that appears to have fixed it.
>>
>> How about that commit queue? Would have caught the crashes before they
>> were checked in.
>>
>> -Ken
>>
>> On Thu, Feb 25, 2010 at 2:53 PM, Oliver Hunt <oli...@apple.com> wrote:
>>
>>> Update to r55258 or later :D
>>>
>>> --Oliver
>>>
>>> On Feb 25, 2010, at 2:46 PM, Kenneth Russell wrote:
>>>
>>>  A change committed some time since yesterday evening has introduced
>>>> many crashes in JSC's GC during testing. A representative stack trace
>>>> is attached.
>>>>
>>>> If you have made changes in this area recently, can you please look into
>>>> this?
>>>>
>>>> Thanks,
>>>>
>>>> -Ken
>>>> <crash.txt>_______________________________________________
>>>> webkit-dev mailing list
>>>> webkit-dev@lists.webkit.org
>>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>>>
>>>
>>>
>>>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Reply via email to