On Tue, Mar 16, 2010 at 1:56 PM, Maciej Stachowiak <m...@apple.com> wrote: > > On Mar 16, 2010, at 1:45 PM, Kenneth Russell wrote: > >> Earlier today I landed https://bugs.webkit.org/show_bug.cgi?id=33416 >> by hand (because the commit queue was blocked), and unfortunately this >> broke some of the WebGL layout tests on the bots. >> >> These tests are passing locally, so the best guess I can make is that >> the hardware or OpenGL versions on the bots are insufficient or buggy. >> >> A couple of questions: >> >> 1. Is there any way to get the per-test output from the test runs on the >> bots? > > Yes. Here is an example from a test run that had WebGL failures: > http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r56077%20(11505)/results.html
Thanks. >> 2. Is there any way to temporarily disable these tests on the bots >> until we can figure out a resolution? The patch for 33416 is generally >> sound, and was blocking further work, so it would be preferable not to >> have to roll it out. > > I would recommend we fully investigate other avenues before considering that > route. Regression tests are not very effective if we just disable them > whenever they start failing. What is your recommendation? I hate to leave tests broken on the bots for hours at a time. Looking at the test failures, the OpenGL implementation on the bots is completely broken when turning on FBO multisampling so we are going to need to figure out a way to detect this case and not try to turn it on. Is there a way to tell what graphics hardware is in each of the bots, in particular Intel integrated graphics vs. ATI/AMD vs. NVIDIA? Thanks, -Ken _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
