On Mar 17, 2010, at 12:14 PM, Kenneth Russell wrote:


I think what
should be done is to get the tree green by skipping these flaky tests; file high-priority bugs against the test authors to fix the flakiness;
and then figure out a way the commit queue can be used for the vast
majority of patches. (A secure repository of committer
username/passwords on the machine actually executing the commit?)

Were the tests flaky because they were badly designed new tests or because
some patch caused them to start flaking out? It does seem like the
SnowLeopard Release bot, at least, has been failing for some time. I've looked back to Monday morning (which seems to be as far back as we have data) and could not find two consecutive green builds of SnowLeopard Release tests. (Leopard bots, on the other hand, seem to be green going pretty far back, which makes me wonder if there might be something wrong with the SL
build slaves.)

As far as I know they are longstanding tests. I've seen a couple of
their names show up before when intermittent failures caused patches
of mine to fail the commit queue. websocket/tests/frame-lengths.html
is one.

I would tend to suspect that the problem is not with the tests but either with the bot configuration or with some patch that made them start failing semi-sporadically.

Regards,
Maciej

_______________________________________________
webkit-dev mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Reply via email to