As I understand it, the single repository is important for allowing developers to atomically commit a patch that includes both a code fix, a corresponding test, and expected results for that test.
-Darin On Fri, Mar 19, 2010 at 11:08 AM, Alexey Proskuryakov <[email protected]> wrote: > > Also, one sometimes needs to update test expectations even for platforms > they don't build on. > > - WBR, Alexey Proskuryakov > > On 19.03.2010, at 10:50, David Levin wrote: > > Checking it into the main WebKit checkout seems very much in keeping with > the standard WebKit practice. Several times folks have noted that they like > only having one respository to deal with (just sync webkit and you're set). > > On a personal note, I appreciate the simplicity of the WebKit approach -- > only having to use git (or svn) vs "git & another script > (sync-webkit-git.py) & gclient" and the associated complexity and multiple > possible points of failure due to the different repositories and multiple > scripts. > > dave > > On Fri, Mar 19, 2010 at 10:35 AM, Dimitri Glazkov > <[email protected]>wrote: > >> I agree that the idea of only pulling down expectations that you would >> actually need sounds great -- in fact we did try to think of ways of >> how this could be accomplished. So far, no great proposal >> materialized, but it doesn't mean the door of opportunity closes at >> this commit. I would think of this as more of a two-step solution: >> >> Step 1: Align Chromium port with the rest of the WebKit world and >> diminish the cost/pain of WebKit gardening. >> Step 2: Come up with a better way to track dependencies and optional >> components in WebKit. >> Step 3: Profit. >> >> :DG< >> >> On Fri, Mar 19, 2010 at 10:26 AM, Evan Martin <[email protected]> wrote: >> > Before you commit it: >> > >> > Would it make sense to stuff this data somewhere outside of the main >> > checkout, like we do in Chrome with the deps/ dir? >> > I know that's a departure from how the WebKit test results currently >> > work, but I also expect people are not going to be too happy about >> > XXXmb of not-useful-to-them data showing up in their checkouts. (I >> > guess a step two of this proposal would be to move the other test >> > results alongside this new location.) >> > >> > Technical details of this proposal are vague, but I wanted to get it >> > out there before you hit the commit button. :) >> > >> > On Fri, Mar 19, 2010 at 10:13 AM, Dimitri Glazkov < >> [email protected]> wrote: >> >> WebKit folks, >> >> >> >> We're finally ready to land our port's expected results in the WebKit >> >> tree. It's been a long journey, but we are now to the point where it >> >> no longer makes sense to keep Chromium expectations separate from the >> >> rest of the WebKit. >> >> >> >> It's a pretty large chunk of files, so please bear with us -- you may >> >> experience longer-than-expected checkout time for this commit. >> >> >> >> We are also actively working on porting test_shell (Chromium's test >> >> harness) to DumpRenderTree, to enable running the tests on WebKit >> >> waterfall. >> >> >> >> Until then, you can see test run results on WebKit canaries: >> >> >> http://build.chromium.org/buildbot/waterfall.fyi/waterfall?branch=&builder=Webkit+(webkit.org)&builder=Webkit+Linux+(webkit.org)&builder=Webkit+Mac+(webkit.org) >> . >> >> >> >> :DG< >> >> _______________________________________________ >> >> webkit-dev mailing list >> >> [email protected] >> >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> >> >> > >> _______________________________________________ >> webkit-dev mailing list >> [email protected] >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> > > _______________________________________________ > webkit-dev mailing list > [email protected] > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > > > > _______________________________________________ > webkit-dev mailing list > [email protected] > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > >
_______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
