As Adam says, "platform" doesn't mean Mac or Windows, it refers to a lower-level of code that is not necessarily browser-specific.
The guiding rule here is that if your code needs to include files outside of the WebCore/platform directory, then it needs to live outside of WebCore/platform. For example, it's a layering violation for WebCore/platform/foo.cpp to include WebCore/rendering/RenderObject.h. Simon On Mar 30, 2010, at 5:19 PM, Adam Barth wrote: > The platform directory contains a lot more than just platform-specific > files. It's the platform upon which WebCore is built. For example, > KURL is in platform even though it's shared by all the ports. I think > the main consideration for whether to put things in platform relate to > the dependencies. For example, platform doesn't depend on the rest of > WebCore. > > As for whether audio should be a top-level concept, that might make > sense. It seems similar to notifications and storage, which are > top-level concepts. > > Adam > > > On Tue, Mar 30, 2010 at 5:04 PM, Chris Rogers <[email protected]> wrote: >> I'm interested in people's opinions on where I should put my audio code in >> WebKit. >> Up to this point I've been assuming I would put my code into: >> WebCore/platform/audio >> But, on further reflection I realize that the majority of source files are >> cross-platform engine code so perhaps it would make more sense to put the >> cross-platform parts into: >> WebCore/audio >> and the platform-specific parts into: >> WebCore/platform/audio >> Does this seem reasonable? >> Cheers, >> Chris _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
