On Wed, May 19, 2010 at 11:22 AM, Jeremy Orlow <[email protected]> wrote: > On Wed, May 19, 2010 at 7:15 PM, Adam Barth <[email protected]> wrote: >> Another option is that the upload command could store a copy of the patch >> locally that you could then use with svn-apply and svn-unapply >> directly. > > What if we added an option to webkit-patch upload that unapplies the patch > at the end? In fact, for the first iteration, it could simply save the > patch in some temporary location and then run 'svn-unapply'. In other > words, do what you just described but without the second webkit-patch run.
I've always wondered the extent to which svn-unapply works for people. It seems like sometime back, svn-unapply got behind svn-apply in terms of functionality (perhaps around the time that support for Git binary diffs was added to svn-apply). This can happen because svn-unapply is written separately from svn-apply. They don't share the same code path and so can get out of synch (this is a FIXME). Maybe when Git users add functionality to svn-apply, they see less of a need to make the corresponding change to svn-unapply since they already have git-reset. But I don't recall seeing any bug reports or complaints about this from svn-unapply users. --Chris _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
