On Thu, Jul 8, 2010 at 10:58 AM, Xan Lopez <x...@gnome.org> wrote: > On Thu, Jul 8, 2010 at 7:54 PM, Adam Barth <aba...@webkit.org> wrote: >> >> 2) Currently the commit-queue only lands if it gets a 100% passing run >> of all the tests. We could instead change it to land if there are no >> new test failures as a result of applying the patch. This check is to >> avoid introducing new failures that are masked by existing failures. > > commit-queue has been pushing stuff all day and many core bots have > been red since yesterday. How is this possible?
Originally, we had the commit-queue to land only if all the core builders were green. One recent change we made to make the commit-queue more agressive is to land when the commit-queue itself sees 100% passing tests on itself. When we were waiting for all the core builders to be green, the commit-queue usually had to wait for me or Eric or another contributor to clean up the entire tree and ping the folks who maintain bots that had gotten sick. My view is, generally, that the commit-queue should act like a contentious committer, which means it should act the way most committers act. Given that folks generally don't wait for all the bots to be green before committing, I felt this change was worth experimenting with. (Note that sheriff-bot still monitors all the core builders and alerts folks of bustage.) Adam _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
