On Fri, Dec 3, 2010 at 2:30 PM, Darin Adler <da...@apple.com> wrote: > > > I think in general the rule should be "Keep your call sites readable, > and convert to enums if you find that the call sites are becoming > inscrutable." > > Beyond the enum guidelines, it’s also true that functions with these > boolean/enum arguments often indicate minor design mistakes. Many times we > would be better off with multiple functions rather than a single function > with an enum argument.
I agree. I prefer to have multiple public functions that are named accordingly than having a single public function with enums. However, we could have a private function with enum that implements these public functions to share code. - Ryosuke
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
