As everyone knows, I'm a proponent of rolling things out more frequently, but that change looks huge. I think we should have a bias against rolling out large changes because they're much harder and disruptive to roll in and out than small changes. (Of course, we should also have a bias against accepting large patches, but sometimes they're necessary, as I assume Oliver's change was.)
Adam On Fri, Apr 15, 2011 at 10:41 AM, Oliver Hunt <oli...@apple.com> wrote: > Indeed, i missed the gtk release one, but the point stands that just rolling > out a patch (which should not roll out the changelogs) without providing any > information about the crash doesn't help anyone. > > --Oliver > > On Apr 15, 2011, at 10:30 AM, Adam Roben wrote: > >> On Apr 15, 2011, at 1:19 PM, Oliver Hunt wrote: >> >>> Don't roll out patches that don't break any core builders, without making >>> some attempt to diagnose the problem or providing information that will >>> make it possible to fix the problem. >> >> The GTK bots are core builders. >> >> -Adam >> > > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
