It looks like only the .idl files get pre-processed. The .in files have comments that start with "#", meaning that they cannot be pre-processed by a C++ preprocessor. We need to change the comment styles for .in files to "//".
I've added https://bugs.webkit.org/show_bug.cgi?id=62114 to track the changes. Thanks, Alex On 6/6/11 8:35 PM, "Eric Seidel" <[email protected]> wrote: >I think our .in files get pre-processed. So you can use normal c++ >preprocessor definitions. > >#if defined(ENABLE_CSS_REGIONS) && ENABLE_CSS_REGIONS > >But I could be remembering wrong... > >On Mon, Jun 6, 2011 at 4:25 AM, Alexandru Chiculita <[email protected]> >wrote: >> Hi, >> Until we have working CSS Regions and CSS Exclusions implementations we >>will >> guard the code with ENABLE_CSS_REGIONS and ENABLE_CSS_EXCLUSIONS. We >>also >> need to guard the property names in CSSPropertyNames.in and >> CSSValueKeywords.in using those flags. >> Has this been discussed before? >> Currently it is done by using different files for optional features. For >> example SVG has SVGCSSPropertyNames.in and SVGCSSValueKeywords.in that >>are >> only used for SVG enabled builds. >> Using a C preprocessor will require changing the comment style, because >>"#" >> is the prefix for directives in C preprocessors. Should I (1) update the >> file to "//" commenting style and use the C preprocessor or (2) just >> implement a simple syntax like the following one? >> ENABLE_CSS_EXCLUSIONS { >> -webkit-wrap-shape >> } >> For (1) we could also use the #include directive for the current >>approach >> #if defined ENABLE_SVG && ENABLE_SVG >> #include "SVGCSSPropertyNames.in" >> #endif >> Regards, >> Alex >> _______________________________________________ >> webkit-dev mailing list >> [email protected] >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> >> _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
