I looked through all the patches. There is a general trouble of that the code is written in very-old C-style yet uses a c++ compiler. I think this will come back to haunt you in the future as more people try to work on the code.
I suspect that there are many memory leaks in the code as written, mostly due to the lack of smart pointers. I'm ready to r+ the patches re-posted with some modern c++ usage. I'm also OK with someone else approving them if EFL style requires this ancient-C (and bad memory-management) look. -eric On Fri, Jun 10, 2011 at 12:10 PM, Eric Seidel <[email protected]> wrote: > This is *so* importnat to the long-term health of your port. > > Congrats! I'm happy to review what I can and will look through them now. > > -eric > > On Fri, Jun 10, 2011 at 12:02 PM, Leandro Pereira > <[email protected]> wrote: >> Hey, >> >> At last, the EFL port of WebKit got a DumpRenderTree implementation! >> We're still working on ironing out a lot of bugs found by some of the >> LayoutTests, but the DRT (and ImageDiff) code has been submitted to >> Bugzilla. It would be awesome if anyone could help reviewing these >> patches. >> >> DumpRenderTree patches: >> https://bugs.webkit.org/show_bug.cgi?id=62034 >> https://bugs.webkit.org/show_bug.cgi?id=61974 >> https://bugs.webkit.org/show_bug.cgi?id=61962 >> https://bugs.webkit.org/show_bug.cgi?id=61958 >> >> ImageDiff patch: >> https://bugs.webkit.org/show_bug.cgi?id=61942 >> >> Thanks, >> Leandro >> _______________________________________________ >> webkit-dev mailing list >> [email protected] >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> > _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
