It's partially my fault. I saw the train wreck coming, but got distracted with other stuff and did not follow through.
I think the problem was that: 1) I should've been more firm in insisting on waiting for feedback from webkit-dev. 2) Brent had no business reviewing that patch. To prevent this from happening again, we should remind everyone to: 1) Only review things they are comfortable with; 2) Seek WebKit elder's review for public-facing APIs I don't think we need an explicit two-level review policy. If anything, we need super-reviewers instead. :DG< On Wed, Jun 22, 2011 at 11:31 AM, Ryosuke Niwa <rn...@webkit.org> wrote: > On Wed, Jun 22, 2011 at 11:28 AM, Simon Fraser <simon.fra...@apple.com> > wrote: >> >> Thank you, Adam. >> >> Given this fiasco, I'm temped to propose that we require two levels of >> review for new web-facing API. > > That sounds reasonable. But adding, say, new CSS property or supporting new > event that has been implemented by other browsers do not seem that risky. > So maybe only "new" in the sense of it hasn't been implemented by other > major browsers? > - Ryosuke > > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
