Thanks everyone. My patch already successfully builds on Mac, because of my updated .exp file which I thought for Windows :)
I got the impression that the not updated .exp file breaks Windows build because I saw the following error on win-ews (now I know I should fix the .def file): 3>Linking... 3> Creating library C:\cygwin\home\buildbot\WebKitBuild\Debug\lib\JavaScriptCore.lib and object C:\cygwin\home\buildbot\WebKitBuild\Debug\lib\JavaScriptCore.exp 3>JavaScriptCore.exp : error LNK2001: unresolved external symbol "private: void __thiscall WTF::StringBuilder::reifyString(void)" (?reifyString@StringBuilder@WTF@@AAEXXZ) 3>C:\cygwin\home\buildbot\WebKitBuild\Debug\bin\JavaScriptCore.dll : fatal error LNK1120: 1 unresolved externals On Sat, Aug 27, 2011 at 1:00 AM, Darin Adler <[email protected]> wrote: > On Aug 26, 2011, at 1:50 AM, Xianzhu Wang (王显著) wrote: > > > I'm developing on Linux. One of my patch failed to build on Windows > because I haven't changed the related .exp file (e.g. JavaScriptCore.exp). > > > > I just did the following on Linux to update the file: > > 1. nm xx.o | grep " T " | sed 's/^.\{19\}/_/' > > 2. replace related lines in the .exp file with the above output > > > > Though it works I guess it's not the correct way. What's the correct way? > > Those exp files are used only on Mac. You’ll need to get someone to compile > on Mac or take advantage of the EWS to get a compile on Mac. The linker > errors can tell you the symbols that should be in the .exp file. > > -- Darin > >
_______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
