BTW I did figure out why (code generators behave differently for overloaded and non-overloaded functions), mentioned that bug in the comments further down, and uploaded a patch to fix it. I'm sorry I didn't have had time to take it further.
On Wed, Aug 31, 2011 at 16:28, David Levin <[email protected]> wrote: > On Wed, Aug 31, 2011 at 5:57 AM, Philippe Normand <[email protected]>wrote: > >> Sorry for the last one. > > Looks like the patch in https://bugs.webkit.org/show_bug.cgi?id=66045 >> is intended to fix this issue for both JSC and V8 code generators, if I >> understood correctly. >> > > Short story: > http://trac.webkit.org/**changeset/94023<http://trac.webkit.org/changeset/94023> > is > correct and we should fix the result that in there now. > > More: > In general, when JSC and V8 disagree, we've gone with JSC in the platform > independent file. > > http://trac.webkit.org/changeset/93713 and http://trac.webkit.org/** > changeset/94168 <http://trac.webkit.org/changeset/94168> didn't do this so > they aren't following what is standard practice. > > The original issue crept in with r93713 which changed this output for v8 > but didn't figure out why -- "No idea as to why the code the code > generator acts differently now". > > dave > > >> >> Philippe >> >> On Wed, 2011-08-31 at 13:40 +0200, Osztrogonac Csaba wrote: >> > Hi, >> > >> > It seems you guys are playing ping-pong with this platform independent >> expected file. >> > Could you decide which one is the correct? >> > >> > br, >> > Ossy >> > >> > http://trac.webkit.org/changeset/93713 >> > >> http://trac.webkit.org/changeset/93713/trunk/LayoutTests/fast/files/create-blob-url-crash-expected.txt >> > -PASS: Not enough arguments >> > +PASS: Type error >> > >> > http://trac.webkit.org/changeset/94023 >> > >> http://trac.webkit.org/changeset/94023/trunk/LayoutTests/fast/files/create-blob-url-crash-expected.txt >> > -PASS: Type error >> > +PASS: Not enough arguments >> > >> > http://trac.webkit.org/changeset/94168 >> > >> http://trac.webkit.org/changeset/94168/trunk/LayoutTests/fast/files/create-blob-url-crash-expected.txt >> > -PASS: Not enough arguments >> > +PASS: Type error >> > _______________________________________________ >> > webkit-dev mailing list >> > [email protected] >> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> > >> >> >> _______________________________________________ >> webkit-dev mailing list >> [email protected] >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> > > -- Tommy Widenflycht, Senior Software Engineer Google Sweden AB, Kungsbron 2, SE-11122 Stockholm, Sweden Org. nr. 556656-6880 And yes, I have to include the above in every outgoing email according to EU law.
_______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
