Re: [webkit-dev] Color profiles in expected.png files

[Dirk Schulze]

The color profile switches automatically for me on running pixel tests with 
Lion or SL. How is it even possible that we got images with different color 
profiles for mac results?

Dirk

Simon Fraser:
> It turns out that some of the layout test expected.png files have color 
> profiles (Generic RGB), and some do not 
> <https://bugs.webkit.org/show_bug.cgi?id=67880>.
> 
> On my Lion machine, at least, this affects the appearance of the standard 
> green color, and causes pixel tests to fail.
> 
> It appears that these files have come from various sources, including Tony 
> Chang's embedding of checksums in image files, and new expected results 
> created on Lion.
> 
> I think we should be consistent about color profiles, and in a way that 
> doesn't break pixel tests. Does anyone want to vote one way or the other?
> 
> Once we decide, we should also have some kind of protection against adding 
> new pixel results which don't follow convention. Maybe webkit-patch can be 
> taught about this.
> 
> Simon
> 
> _______________________________________________
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev