On Mon, Oct 10, 2011 at 6:35 AM, Vamshi <[email protected]> wrote: > > I proposed patch for the bug ID:20040, https://bugs.webkit.org/show_** > bug.cgi?id=20040 <https://bugs.webkit.org/show_bug.cgi?id=20040> which > resulted in failure of few layout testcases. After analysis, I found that > the expected.txt needs to be modified in order to make the test cases pass. > because, my patch is to fix the "extra" vertical spacing across table > sections. Hence it will definitely change the size of the tables and its > parent render box and render layers. Hence the test cases were failing. > I am able run layout test cases for chromium-Linux, I guess the same test > cases would fail on other platforms too. > So I have the following doubts to proceed further: > > 1. Should I request some of the reviewers to review my patch before I > actually go and modify all expected.txt files ? > 2. Do i need to modify expected.txt files for all the platforms? If so, Is > it required to make set up for each of the platforms? >
People usually land their patches (with a platform for at least one platform) first and then grab results out of the bots (build.webkit.org). You can also ask for a help on #webkit if you need to rebaseline png files (note: only Chromium port' bots run pixel tests and the rest of bots only compare .txt files). - Ryosuke
_______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
