Sure. Feel free to add that feature. Obviously we don't want to force people to use it, but it might become popular.
Adam On Jan 5, 2012 3:12 AM, "Hajime Morrita" <[email protected]> wrote: > Does it make sense for webkit-patch post/upload to support "--ping" to > acknowledge a set of reviewers using a specific form of comment? As a > reviewer, some kind of specific pattern would be helpful to filter > such ping mails which contain, for example, "ping:morrita@". > > Maybe this can be taken as a step backward to the "by name" review > request which we had declined. But at least for me, such kind of > filterable mail would be gret tool to pick bugs for review. Even > though this won't help some high-traffic reviewers, it won't hurt at > least. I've been overwhelmed by the stream of Bugzilla mail coming... > > What do you think? > > -- > morrita > > > On Thu, Jan 5, 2012 at 5:03 PM, Andreas Kling <[email protected]> wrote: > > On Thu, Jan 5, 2012 at 7:49 AM, Adam Barth <[email protected]> wrote: > >> > >> Not to pick on anyone in particular, but when reading bugmail I > >> occasionally see messages like "pinging for review." I review a lot > >> of patches, but I don't find these messages particularly helpful > >> because I don't know whether I'm supposed to review the patch. > >> > >> Another approach that might work better for you is to address your > >> comment at someone in particular. For example, if the message says > >> "Adam, can you please review this patch?", then there's a pretty good > >> chance I'll click through and try to answer your question. > >> > >> If you're unsure who to ask for review, one approach is to look at the > >> svn log for the files you're changing and see who has written/reviewed > >> patches for those files recently. You can also ask folks who've been > >> around the project for a while to suggest someone. > > > > > > True that. > > > > You can also find reviewers for a particular area here on the WebKit Team > > wiki page: http://trac.webkit.org/wiki/WebKit%20Team (and I encourage > people > > to keep their entry up-to-date.) > > > > -Kling > > > > _______________________________________________ > > webkit-dev mailing list > > [email protected] > > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > >
_______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
