How did you run the layout tests? The run-webkit-tests script should take care of starting the Apache web server for you with all the configuration options set. This is usually how you run just the http tests for a debug build (after running the build-webkit script):
./Tools/Scripts/run-webkit-tests --debug http Do the same tests pass without your changes? That would be the first thing to check. You should also write at least one layout test that tests the new abort() method. See Step 4 here: <http://www.webkit.org/coding/contributing.html> Dave On Jan 10, 2012, at 6:46 AM, huangxueqing wrote: > Hi Dave: > I have implemented abort(), but some of result of layout test in > Layout/http/tests/appcache was failed. And i copy appcache dir into htdocs > dir of apache raise failure again. I think due to some configuration > problems. Should i configure something to correct it? > thanks. > > huangxueqing > >> The abort() method is defined here: >> <http://dev.w3.org/html5/spec/Overview.html#applicationcache> > >> There is no abort() method defined in >> Source/WebCore/loader/appcache/DOMApplicationCache.idl. > >> Please file a bug and attach a patch for review. See: >> <http://www.webkit.org/coding/contributing.html> > >> Thanks! > >> Dave > > > On Jan 7, 2012, at 7:04 AM, huangxueqing wrote: > >>> hi all: >>> The latest html5 specification add a API "applicationCache.abort()" for >>> offline web applications. I had implement offline web app for our browser >>> in main process this month except this interface since it need to make some >>> modifications in WebCore. >>> I want to know whether any guys had planed to implement it? If not and >>> this feature was necessary, maybe i will file a bug and implement this api >>> in next month. >>> thanks. >>> >>> huangxueqing >>> Baidu, Inc. >>> _______________________________________________ >>> webkit-dev mailing list >>> [email protected] >>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
