Hello Antonio, Ok, I'm going to update the test results for EFL port as GTK port's way.
- gyuyoung. ------- Original Message ------- Sender : Antonio Gomes<[email protected]> Date : 2012-01-17 02:54 (GMT+09:00) Title : Re: [webkit-dev] Question regarding rebaseline for Layout Test Result for EFL port I would say GTK's way is pretty acceptable in this case. On Mon, Jan 16, 2012 at 3:21 AM, Gyuyoung Kim <[email protected]> wrote: Hello WebKit folks. It looks that the result of layout test for EFL port needs rebaseline because of 101343. The revision modified line spacing of font in SimpleFontDataFreeType.cpp, and it seems that the existing layout test result of EFL port was influenced by it. (http://trac.webkit.org/changeset/101343) 3,936 test cases are failed after the revision (101343). * EFL port's layout test result with r101343 => Results: 16139/27915 tests passed (57.8%) => Tests to be fixed (11776): 4423 text diff mismatch (37.6%) 9 image mismatch ( 0.1%) 7344 skipped (62.4%) * EFL port's layout test Result without r101343 => Results: 20074/27915 tests passed (71.9%) => Tests to be fixed (7841): 1 test timed out ( 0.0%) 487 text diff mismatch ( 6.2%) 9 image mismatch ( 0.1%) 7344 skipped (93.7%) It looks GTK port also did rebaseline due to the revision. - http://trac.webkit.org/changeset/101354 - http://trac.webkit.org/changeset/101352 - http://trac.webkit.org/changeset/101351 - And so on. I think EFL port also needs to do rebaseline for layout test result. GTK port did rebaseline without review because patch is too huge. Is there any processes for rebaseline ? - gyuyoung _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
