Hello... I have a small addition to RenderThemeWin::determineState so it will
handle indeterminate (mixed) state for checkbox. I am not sure who owns this
code.
Below is the new code. The addition are the two lines to check for
indeterminate state on CheckboxPart.
This gives correct rendering for Layout test: fast/forms/indeterminate.html
unsigned RenderThemeWin::determineState(RenderObject* o)
{
unsigned result = TS_NORMAL;
ControlPart appearance = o->style()->appearance();
if (!isEnabled(o))
result = TS_DISABLED;
else if (isReadOnlyControl(o) && (TextFieldPart == appearance ||
TextAreaPart == appearance || SearchFieldPart == appearance))
result = TFS_READONLY; // Readonly is supported on textfields.
else if (isPressed(o)) // Active overrides hover and focused.
result = TS_ACTIVE;
else if (supportsFocus(appearance) && isFocused(o))
result = TS_FOCUSED;
else if (isHovered(o))
result = TS_HOVER;
if (isChecked(o))
result += 4; // 4 unchecked states, 4 checked states.
else if (isIndeterminate(o) && appearance == CheckboxPart)
result += 8;
return result;
}
Thanks,
Lynn Neir
_______________________________________________
webkit-dev mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
