On Mar 8, 2012, at 12:05 PM, Ojan Vafai <[email protected]> wrote: > Whoops. A lot of these were from me yesterday. Sorry, I didn't realize I > didn't have my subversion config set correctly. > > I went to fix up my commits from yesterday and realized that a very large > percentage of the pngs in the LayoutTests tree have the wrong svn:mime-type. > Is anyone opposed to me doing a bulk fix for all the pngs?
No. I have done this myself multiple times in the past. > > find LayoutTests | grep \.png$ | grep -v \.svn | xargs svn ps svn:mime-type > image/png I tend to be more conservative and only set the property on PNGs that don’t already have it set to something. > > > > On Thu, Mar 8, 2012 at 1:52 AM, Ashod Nakashian <[email protected]> > wrote: > Please let's also enforce svn:eol-style to LF for all scripts as this is > breaking (at least) the bash scripts that are checked-out with native style > on Windows. Some bash versions don't like CR. Please see a (failed) attempt > at fixing this manually[1]. > > I also believe we should mark all (Bash/Perl/Python) scripts as executable. > It's best to at least automate it, if not also check for violations via > check-webkit-style. (And for the loving of all that's good, would someone > please help with this bug[1]?) > > [1] https://bugs.webkit.org/show_bug.cgi?id=79509 > > -Ash > > From: Simon Fraser <[email protected]> > To: Eric Seidel <[email protected]> > Cc: WebKit Development <[email protected]> > Sent: Thursday, March 8, 2012 3:37 AM > Subject: Re: [webkit-dev] Please set the svn:mime-type property on binary > files before committing > > The best way to enforce it would be with a pre-commit hook: > <https://bugs.webkit.org/show_bug.cgi?id=80548> > > Simon > > On Mar 7, 2012, at 3:33 PM, Eric Seidel wrote: > > > Unless this is enforced by a tool, it's very likely to be forgotten. > > > > https://bugs.webkit.org/show_bug.cgi?id=75824 > > https://bugs.webkit.org/show_bug.cgi?id=75825 > > > > > > On Wed, Mar 7, 2012 at 3:21 PM, Dan Bernstein <[email protected]> wrote: > >> Please set the svn:mime-type property on binary files that you add to the > >> tree, such as *-expected.png, before committing. Otherwise the resulting > >> webkit-changes message will include those files as text, which is > >> inconvenient. > >> > >> Thanks. > >> > >> _______________________________________________ > >> webkit-dev mailing list > >> [email protected] > >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > >> > > _______________________________________________ > > webkit-dev mailing list > > [email protected] > > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > _______________________________________________ > webkit-dev mailing list > [email protected] > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > > > _______________________________________________ > webkit-dev mailing list > [email protected] > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > > _______________________________________________ > webkit-dev mailing list > [email protected] > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
_______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
